From: Martin Kampas <martin.kampas@ubedi.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Incorrect done TODO keywords highlighting in column view
Date: Mon, 19 Oct 2020 07:29:05 +0200 [thread overview]
Message-ID: <7479817.9BdLuGDDFr@gt1> (raw)
In-Reply-To: <87k0vnz0eh.fsf@kyleam.com>
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
Hi Kyle,
You are right, I completely forgot about columns view under the "regular" buffers.
Updated patch below.
BR,
Martin
From 288c157ea95e00de4b508e0fd257b51857e097b9 Mon Sep 17 00:00:00 2001
From: Martin Kampas <martin.kampas@ubedi.net>
Date: Mon, 19 Oct 2020 07:22:57 +0200
Subject: [PATCH] org-colview: Fix done keywords highlighting in agenda buffers
* lisp/org-colview.el (org-agenda-columns): Populate
org-done-keywords from org-done-keywords-for-agenda or the done keywords
will use the same face as those not-done.
---
lisp/org-colview.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index e50a4d7c8..565bdb2dd 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1586,6 +1586,7 @@ PARAMS is a property list of parameters:
(move-marker org-columns-begin-marker (point))
(setq org-columns-begin-marker (point-marker)))
(let* ((org-columns--time (float-time))
+ (org-done-keywords org-done-keywords-for-agenda)
(fmt
(cond
((bound-and-true-p org-overriding-columns-format))
--
2.28.0
[-- Attachment #2: Type: text/html, Size: 3493 bytes --]
next prev parent reply other threads:[~2020-10-19 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 5:50 Bug: Incorrect done TODO keywords highlighting in column view Martin Kampas
2020-10-18 21:31 ` Kyle Meyer
2020-10-19 5:29 ` Martin Kampas [this message]
2020-10-20 4:43 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7479817.9BdLuGDDFr@gt1 \
--to=martin.kampas@ubedi.net \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).