emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Martin Kampas <martin.kampas@ubedi.net>
To: emacs-orgmode@gnu.org
Subject: Bug: Incorrect done TODO keywords highlighting in column view
Date: Fri, 09 Oct 2020 07:50:58 +0200	[thread overview]
Message-ID: <7117090.b6naEkYVYe@gt1> (raw)

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

Hi,

In columns view, all TODO keywords except those with face set explicitly with org-todo-
keyword-faces are red. Done keywords should be green.

Patch below.

BR,
Martin

From a4df0da1057afbe90ea0e457158082b15386a164 Mon Sep 17 00:00:00 2001
From: Martin Kampas <martin.kampas@ubedi.net>
Date: Fri, 9 Oct 2020 07:43:17 +0200
Subject: [PATCH] org-colview: Fix done TODO keywords highlighting

* lisp/org-colview.el (org-columns--overlay-text): Populate
org-done-keywords from org-done-keywords-for-agenda or the done keywords
will use the same face as not-done keywords.
---
 lisp/org-colview.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index e50a4d7c8..827f57e5e 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -365,7 +365,9 @@ ORIGINAL is the real string, i.e., before it is modified by
                   org-tags-special-faces-re
                   (lambda (m) (propertize m 'face (org-get-tag-face m)))
                   v nil nil 1)))
-              ("TODO" (propertize v 'face (org-get-todo-face original)))
+              ("TODO"
+               (let ((org-done-keywords org-done-keywords-for-agenda))
+                 (propertize v 'face (org-get-todo-face original))))
               (_ v)))))
 
 (defvar org-columns-header-line-remap nil
-- 
2.28.0



[-- Attachment #2: Type: text/html, Size: 4536 bytes --]

             reply	other threads:[~2020-10-09  5:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  5:50 Martin Kampas [this message]
2020-10-18 21:31 ` Kyle Meyer
2020-10-19  5:29   ` Martin Kampas
2020-10-20  4:43     ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7117090.b6naEkYVYe@gt1 \
    --to=martin.kampas@ubedi.net \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: Bug: Incorrect done TODO keywords highlighting in column view' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).