Re: Org-mode version 6.32trans and 6.21b; Strange interaction between whitespace-mode and cust. org-ellipsis

[Carsten Dominik <carsten.dominik@gmail.com>]

On Dec 3, 2009, at 10:34 PM, Martin Pohlack wrote:

> Carsten Dominik wrote:
>> Hi Martin, this looks to me like a bug in whitespace.el, why does it
>> override the display table org-mode is using?
>
> Hmm, my understanding is that each buffer can have its own display
> table, buffer-display-table.  whitespace-mode has to modify this table
> (or install an own one) if it wants to do buffer-local modifications.
> So I think it modifies org-mode's table but doesn't override it.
>
> My irritation is that by doing so, it does modifies some global state
> that effects other buffers.
>
> A short look into org.el shows that org-display-table is never made
> buffer local, so this data structure is shared across all org-mode  
> buffers?

Yes, this is the idea, and it seems only logical to me.  So why
do you want different settings in different Org buffers for
whitespace?  So far I am unconvinced that creating a new
table in each buffer with the right thing to do.

- Carsten


>
> The following hack seems to solve this problem:
>
> --- org.el.bak	2009-12-03 22:31:07.000000000 +0100
> +++ org.el	2009-12-03 22:31:48.000000000 +0100
> @@ -427,9 +427,6 @@
> 		 (face :tag "Face" :value org-warning)
> 		 (string :tag "String" :value "...#")))
>
> -(defvar org-display-table nil
> -  "The display table for org-mode, in case `org-ellipsis' is non- 
> nil.")
> -
> (defgroup org-keywords nil
>   "Keywords in Org-mode."
>   :tag "Org Keywords"
> @@ -4170,8 +4167,7 @@
>   (when (and org-ellipsis
>              (fboundp 'set-display-table-slot) (boundp
> 'buffer-display-table)
> 	     (fboundp 'make-glyph-code))
> -    (unless org-display-table
> -      (setq org-display-table (make-display-table)))
> +    (setq org-display-table (make-display-table))
>     (set-display-table-slot
>      org-display-table 4
>      (vconcat (mapcar
>
>
> Cheers,
> Martin

- Carsten