From: Martin Pohlack <mp26@os.inf.tu-dresden.de>
To: Carsten Dominik <carsten.dominik@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Org-mode version 6.32trans and 6.21b; Strange interaction between whitespace-mode and cust. org-ellipsis
Date: Thu, 03 Dec 2009 22:34:19 +0100 [thread overview]
Message-ID: <4B182EDB.3070209@os.inf.tu-dresden.de> (raw)
In-Reply-To: <50ED3D70-FE6A-4903-BACC-9EC7D021EC22@gmail.com>
Carsten Dominik wrote:
> Hi Martin, this looks to me like a bug in whitespace.el, why does it
> override the display table org-mode is using?
Hmm, my understanding is that each buffer can have its own display
table, buffer-display-table. whitespace-mode has to modify this table
(or install an own one) if it wants to do buffer-local modifications.
So I think it modifies org-mode's table but doesn't override it.
My irritation is that by doing so, it does modifies some global state
that effects other buffers.
A short look into org.el shows that org-display-table is never made
buffer local, so this data structure is shared across all org-mode buffers?
The following hack seems to solve this problem:
--- org.el.bak 2009-12-03 22:31:07.000000000 +0100
+++ org.el 2009-12-03 22:31:48.000000000 +0100
@@ -427,9 +427,6 @@
(face :tag "Face" :value org-warning)
(string :tag "String" :value "...#")))
-(defvar org-display-table nil
- "The display table for org-mode, in case `org-ellipsis' is non-nil.")
-
(defgroup org-keywords nil
"Keywords in Org-mode."
:tag "Org Keywords"
@@ -4170,8 +4167,7 @@
(when (and org-ellipsis
(fboundp 'set-display-table-slot) (boundp
'buffer-display-table)
(fboundp 'make-glyph-code))
- (unless org-display-table
- (setq org-display-table (make-display-table)))
+ (setq org-display-table (make-display-table))
(set-display-table-slot
org-display-table 4
(vconcat (mapcar
Cheers,
Martin
next prev parent reply other threads:[~2009-12-03 21:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 19:02 Org-mode version 6.32trans and 6.21b; Strange interaction between whitespace-mode and cust. org-ellipsis Martin Pohlack
2009-12-03 8:20 ` Carsten Dominik
2009-12-03 21:34 ` Martin Pohlack [this message]
2009-12-04 12:26 ` Carsten Dominik
2009-12-04 15:41 ` Martin Pohlack
2009-12-14 16:27 ` Carsten Dominik
2009-12-14 19:51 ` Martin Pohlack
2010-01-01 13:34 ` Carsten Dominik
-- strict thread matches above, loose matches on Subject: below --
2009-12-02 19:06 Martin Pohlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B182EDB.3070209@os.inf.tu-dresden.de \
--to=mp26@os.inf.tu-dresden.de \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).