Icalendar Export Broken in Git Version

Icalendar Export Broken in Git Version

[Charles Philip Chan]

Hello:

I tried to export an icalendar file with the current git version of
org-mode and it failed. I debugged it by loading org-install on a clean
Emacs with no init files and this is what I got:

,----
| Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
|   byte-code("\306 \210\b\203\0\307 \310\216\b *\204\0\311 \210\312u\210\313\314\315\"\210\316\224\317\316!\320 \321\315\322\323\217@\324\325\315\326\"!A\324\325\315\327\"\206F\x0eB\205F\330 \321B#C\324\325\315\331\332#!DE\203_\333 \202f\334 \206f\335 F\336 G\325\315\337\"\211H\205z\340H!H\341I\315\211JK\342L!\203\237\316\225b\210\317\343!M\344\345M\"?\202\322e\nNZ]\n{O\344\346\v\"\203\273\315\347\350\321\315\v$\202\274\vM\344PO\"J\344QO\"K\351 RS\204\346\x0eJ\204\346\x0eK\204\346\313\314\321\"\210T\203\372\352\315\353\354\f\"\"\203\372\313\314\321\"\210J\203\x01R\203\f\355U>?\202\x01\356U>?\203\x01\313\314\321\"\210K\2038\x0eR\203+\355V>?\2020\356V>?\2038\313\314\321\"\210J\203A\357\202K\x0eK\203J\360\202K\361W\344X@\"\204_\344Y@\"\203h\347\341\321\211@$@\344\362\v\"\203\203\363\364\317\365\v\"\366\"A\367\317\343\v\"RZ\202\206\341ZA\206\215\x0e@A\315\370\371\217[H\316V\204\243\x0e\\\316V\203\310\x0e[@\203\310\x0e[A@\203\310\365[8\203\310\372\373AH\206\302\x0e\\#I\202\313\341I)\344]A\"\203\357\347\374\225\203\343\317\374A\"\202\350\317\343A\"\321\211A$AJ\203\372\375APAK\203\x02\376APA\344\377\v\"\203<r^q\210\v\343\312O_\201`\316\343\201F\201a\x0eWFQ_%\210_\201a\x0eA\201b\261\210*\202\230\201c\372\201d\x0eWFP\201e\v\201f\"\201e\x0eM\201g\r#ZAC\203v\344\201h\x0eC\"\203v\201i\x0eCP\202w\341D\203\217\344\201h\x0eD\"\203\217\201j\x0eDP\202\220\341GI&\n!\210\315\207" [org-icalendar-verify-function save-match-data-internal pos ts tags inc org-agenda-skip match-data ((byte-code "\301\b\302\"\207" [save-match-data-internal set-match-data evaporate] 3)) outline-next-heading -1 throw :skip nil 0 match-string org-get-tags-at t (byte-code "\300\301\302!!\207" [org-icalendar-cleanup-string org-get-heading t] 3) ((error (throw :skip nil))) org-icalendar-cleanup-string org-entry-get "SUMMARY" "DESCRIPTION" org-get-entry "LOCATION" selective org-id-get-create org-id-get org-id-new org-export-get-categories "APPT_WARNTIME" string-to-number "" looking-at 1 string-match "[0-9]\\{1,2\\}:[0-9][0-9]" "[0-9]\\{1,2\\}:[0-9][0-9]-\\([0-9]\\{1,2\\}:[0-9][0-9]\\)" replace-match "\\1" org-get-todo-state delq mapcar #[(x) "\b	\235\207" [x org-export-exclude-tags] 2] event-if-todo event-if-not-todo "DL-" "SC-" "TS-" ...] 13)
|   org-print-icalendar-entries(nil)
|   byte-code("\306\b!\210\307\b!q\210	\204$\310\n!\311\312\v!!\313Q\307\f!rq\210\314 \210)\x1c\206.\311\312\v!!\211\x1d9\203;\315\x1d!\x1d\x1e	\203V\x0e\x1f\204[\316\211\x1f\203[\317 !\210\202[\317\x1d!\210\320	!\210	\203h\x0e!\203l	\204\236	\203|\x0e\"\203|\321\322!\210\323 \210\324 \210q\210\325\326!\210\327 \210\325\330!\210\331\332!\203\236\x0e\247\203\236\333\x1a!\210)\306\207" [file combine dir buffer-file-name ical-file ical-buffer org-check-agenda-file org-get-agenda-file-buffer file-name-as-directory file-name-sans-extension file-name-nondirectory ".ics" erase-buffer symbol-name t org-start-icalendar-file org-print-icalendar-entries require org-bbdb org-bbdb-anniv-export-ical org-finish-icalendar-file run-hooks org-before-save-iCalendar-file-hook save-buffer org-after-save-iCalendar-file-hook boundp org-wait sit-for org-category category standard-output started org-icalendar-combined-name files org-icalendar-include-bbdb-anniversaries] 5)
|   org-export-icalendar(nil "/home/hoor/Desktop/Projects/plans/test.org")
|   org-export-icalendar-this-file()
|   call-interactively(org-export-icalendar-this-file record nil)
|   command-execute(org-export-icalendar-this-file record)
|   execute-extended-command(nil "org-export-icalendar-this-file")
|   call-interactively(execute-extended-command nil nil)
`----

If I replace org-icalendar with the version that comes with my Emacs
24.1.50.1 everything works.

Thanks,
Charles

-- 
"If you want to travel around the world and be invited to speak at a lot
of different places, just write a Unix operating system."
(By Linus Torvalds)

Re: Icalendar Export Broken in Git Version

[Bastien]

Hi Charles,

Charles Philip Chan <cpchan@bell.net> writes:

> I tried to export an icalendar file with the current git version of
> org-mode and it failed. I debugged it by loading org-install on a clean
> Emacs with no init files and this is what I got:

Fixed, thanks for reporting this.

-- 
 Bastien

Re: Icalendar Export Broken in Git Version

[Nick Dokos]

Charles Philip Chan <cpchan@bell.net> wrote:

> Hello:
> 
> I tried to export an icalendar file with the current git version of
> org-mode and it failed. I debugged it by loading org-install on a clean
> Emacs with no init files and this is what I got:
> 
> ,----
> | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
> |   ...
> |   org-print-icalendar-entries(nil)
> |   ...
> |   org-export-icalendar(nil "/home/hoor/Desktop/Projects/plans/test.org")
> |   org-export-icalendar-this-file()
> |   call-interactively(org-export-icalendar-this-file record nil)
> |   command-execute(org-export-icalendar-this-file record)
> |   execute-extended-command(nil "org-export-icalendar-this-file")
> |   call-interactively(execute-extended-command nil nil)
> `----
> 
> If I replace org-icalendar with the version that comes with my Emacs
> 24.1.50.1 everything works.
> 

There are only two recent commits against org-icalendar. The second one
mentions org-print-icalendar-entries, so I bet that's the culprit :-)

,----
| commit 2cd4333398e16ddb8d321c2ab6e4fac18733b500
| Author: Bastien Guerry <bzg@altern.org>
| Date:   Sun Aug 5 18:59:51 2012 +0200
| 
|     Fix two compiler warnings.
| 
| commit 216768531f2661c4b1890eef6454f58e6cb8a241
| Author: Bastien Guerry <bzg@altern.org>
| Date:   Sun Aug 5 11:30:23 2012 +0200
| 
|     org-icalendar.el: Let APPT_WARNTIME take precedence over ̀org-icalendar-alarm-time'.
|     
|     * org-icalendar.el (org-print-icalendar-entries): Let
|     APPT_WARNTIME take precedence over ̀org-icalendar-alarm-time'.
`----

For future reference, if you can reproduce the problem with *uncompiled* org-mode,
the backtrace is going to be much more readable (no byte code hieroglyphics). Just
something to keep in mind.

Nick

Re: Icalendar Export Broken in Git Version

[Charles Philip Chan]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

Nick Dokos <nicholas.dokos@hp.com> writes:

Hi Nick:

Thanks, Bastien already fixed it.

> There are only two recent commits against org-icalendar. The second
> one mentions org-print-icalendar-entries, so I bet that's the culprit
> :-)

I figured that it was that commit too when I grepped the git log. :-)

> For future reference, if you can reproduce the problem with
> *uncompiled* org-mode, the backtrace is going to be much more readable
> (no byte code hieroglyphics). Just something to keep in mind.

Thanks, I didn't know that.

Charles

-- 
"If you want to travel around the world and be invited to speak at a lot
of different places, just write a Unix operating system."
(By Linus Torvalds)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]