Re: [PATCH] Resolve regexp ambiguity for item headers

[Mats Kindahl <mats.kindahl@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]


On 09/10/2012 08:24 PM, Nicolas Goaziou wrote:
> Hello,
>
> Mats Kindahl <mats.kindahl@oracle.com> writes:
>
>> I solved this issue by requiring that there should always be a headline
>> text (this is after all an assumption made in the code) and rewrote the
>> org-complex-heading-regexp accordingly.
> Actually, I have recently committed a change going exactly the opposite
> way. I'm not certain which solution is better, but I tend to think empty
> headlines should be valid and parts of Org choking on empty headlines
> should be fixed.

Hi Nicolas,

Interesting. :)

Well... the most important point for me is that it shouldn't choke on
these lines, but otherwise I'm open to suggestions.

My rationale for doing it this way was:

  * The code I looked at assumes that the headline text is there, so
    it's likely that it's the common assumption.
  * It is clearly the case that todo keywords are optional.
  * It is not so clear that the headline text is optional

However:

  * The regular expression matches completely empty headlines, so maybe
    the intention is to allow matching items with just a todo keyword?

I would be very interested if anybody could shed some light on this.

Best wishes,
Mats Kindahl

-- 
Senior Principal Software Developer
Oracle, MySQL Department


[-- Attachment #2: Type: text/html, Size: 2089 bytes --]