emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Mats Kindahl <mats.kindahl@oracle.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: [PATCH] Resolve regexp ambiguity for item headers
Date: Mon, 10 Sep 2012 15:20:34 +0200	[thread overview]
Message-ID: <504DE922.1000707@oracle.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1256 bytes --]

Hi!

I use org-mode quite a lot of most things and also have a number of
"workflows" in my setup, use columnview quite a lot, and also have the
habit of entering whatever text I need to write to resolve an issue
under the item in org-mode format (quite convenient, then I can just
export the subtree and send it as mail).

I have frequently run up against the issue that when trying to generate
a column view for a file, it aborts with a strange error. Since this has
become more frequent lately, I decided to resolve it.

It turns out that if you have something that looks like this:

    * Top level

    ** TODO something

    *** Proposal

    Blabla

    *** Submitted

    Some more blaha.

and you have "SUBMITTED" as one of your todo keywords, this line will be
interpreted as an item with a keyword but no headline. Since a lot of
code assumes that there is always a headline, many functions can get a
"nil" as a headline, failing miserably.

I solved this issue by requiring that there should always be a headline
text (this is after all an assumption made in the code) and rewrote the
org-complex-heading-regexp accordingly.

Patch is attached.

Just my few cents,
Mats Kindahl

-- 
Senior Principal Software Developer
Oracle, MySQL Department


[-- Attachment #1.2: Type: text/html, Size: 1807 bytes --]

[-- Attachment #2: 0001-Resolved-regexp-ambiguity-for-item-headers.patch --]
[-- Type: text/x-patch, Size: 1623 bytes --]

From bc3c021d06bb6f0b5971959f769216defae200bd Mon Sep 17 00:00:00 2001
From: Mats Kindahl <mats.kindahl@oracle.com>
To: emacs-orgmode@gnu.org
Date: Sun, 9 Sep 2012 21:53:45 +0200
Subject: [PATCH] Resolved regexp ambiguity for item headers
X-IMAPbase: 1347255850 2
Status: O
X-UID: 1

* lisp/org.el (org-complex-heading-regexp): Resolve ambiguity in heading regexp
in favor of keywordless headline

When a simple headline is provided that just contain a todo keyword, the
regular expression will match so that the heading is treated as containing just
a keyword and no headline. Since org-column-compact-links only accept a
headline text (and not nil), this causes problems with called from
org-columns-cleanup-item. This occurs if a 'columnview' dynamic block is used
to capture a column view.

This patch solves the problem by re-writing the org-complex-heading-regexp to
require a headline text instead of allowing it to be optional. This means that
items containing only a single word that also happens to be a todo keyword is
interpreted as a headline with no todo keyword and just a headline text.
---
 lisp/org.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index fef7597..e990f49 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4824,7 +4824,7 @@ but the stars and the body are.")
 	    (concat "^\\(\\*+\\)"
 		    "\\(?: +" org-todo-regexp "\\)?"
 		    "\\(?: +\\(\\[#.\\]\\)\\)?"
-		    "\\(?: +\\(.*?\\)\\)?"
+		    " +\\(.+?\\)"
 		    (org-re "\\(?:[ \t]+\\(:[[:alnum:]_@#%:]+:\\)\\)?")
 		    "[ \t]*$")
 	    org-complex-heading-regexp-format
-- 
1.7.9.5


             reply	other threads:[~2012-09-10 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 13:20 Mats Kindahl [this message]
2012-09-10 18:24 ` [PATCH] Resolve regexp ambiguity for item headers Nicolas Goaziou
2012-09-10 19:35   ` Mats Kindahl
2012-09-12 14:49     ` Nicolas Goaziou
2012-09-19  9:14       ` Bastien
2012-09-19  9:19         ` Mats Kindahl
2012-09-19 13:58           ` Nicolas Goaziou
2012-09-19 16:51             ` Bastien
2012-09-19 18:14               ` Nick Dokos
2012-09-21  8:56                 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504DE922.1000707@oracle.com \
    --to=mats.kindahl@oracle.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).