From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix agenda bulk refile bug
Date: Wed, 26 Aug 2009 16:49:28 +0200 [thread overview]
Message-ID: <36A91EF9-AD4F-4152-9C9A-5090A32FCF9E@gmail.com> (raw)
In-Reply-To: <1251297334-10504-1-git-send-email-bernt@norang.ca>
Applied, thanks.
- Carsten
On Aug 26, 2009, at 4:35 PM, Bernt Hansen wrote:
> Fix bulk refiling in the agenda due to commit
> 9ec5529 (Fix jumping to last refile location in agenda, 2009-08-20)
>
> This restores the original behaviour.
> ---
> This patch is available in git://git.norang.ca/org-mode for-carsten
>
> As it turns out the revert of the previous patch generated conflicts
> and I reverted it incorrectly :-P. The following patch applied on top
> of master seems to fix the problem.
>
> Bernt
>
> lisp/org-agenda.el | 17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 84d6566..d915e46 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -5481,18 +5481,17 @@ If this information is not given, the
> function uses the tree at point."
> (org-agenda-error)))
> (buffer (marker-buffer marker))
> (pos (marker-position marker))
> - (rfloc))
> - (setq rfloc (or rfloc
> + (rfloc (or rfloc
> (org-refile-get-location
> (if goto "Goto: " "Refile to: ") buffer
> org-refile-allow-creating-parent-nodes))))
> - (with-current-buffer buffer
> - (save-excursion
> - (save-restriction
> - (widen)
> - (goto-char marker)
> - (org-remove-subtree-entries-from-agenda)
> - (org-refile goto buffer rfloc))))))
> + (with-current-buffer buffer
> + (save-excursion
> + (save-restriction
> + (widen)
> + (goto-char marker)
> + (org-remove-subtree-entries-from-agenda)
> + (org-refile goto buffer rfloc)))))))
>
> (defun org-agenda-open-link (&optional arg)
> "Follow the link in the current line, if any.
> --
> 1.6.4.1.331.gda1d56
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2009-08-26 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 16:17 [PATCH] Fix jumping to last refile location in agenda Bernt Hansen
2009-08-26 4:41 ` Carsten Dominik
2009-08-26 13:53 ` Bernt Hansen
2009-08-26 14:11 ` Bernt Hansen
2009-08-26 14:11 ` Carsten Dominik
2009-08-26 14:23 ` Bernt Hansen
2009-08-26 14:35 ` [PATCH] Fix agenda bulk refile bug Bernt Hansen
2009-08-26 14:49 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36A91EF9-AD4F-4152-9C9A-5090A32FCF9E@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).