Re: [PATCH] Fix jumping to last refile location in agenda

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix jumping to last refile location in agenda
Date: Wed, 26 Aug 2009 16:11:27 +0200	[thread overview]
Message-ID: <97F810D1-4F60-40E7-8DAB-D816F27310E4@gmail.com> (raw)
In-Reply-To: <87zl9md6m2.fsf@gollum.intra.norang.ca>

So should I revert, or do you have  a fix?

- Carsten

On Aug 26, 2009, at 3:53 PM, Bernt Hansen wrote:

> Argh.  I think this commit breaks bulk refiling from the agenda.
>
> If I mark two entries (with m) and then B r and enter a location I  
> get a
> Refile: prompt in the mini buffer.
>
> Sorry about that.
>
> -Bernt
>
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Applied, thanks.
>>
>> - Carsten
>>
>> On Aug 25, 2009, at 6:17 PM, Bernt Hansen wrote:
>>
>>> C-u C-u C-c C-w now goes to the last refile location in the agenda.
>>> This is the same behaviour as org-refile (when used in an org file)
>>> ---
>>> Carsten,
>>>
>>> This patch allows C-u C-u C-c C-w on any line in the agenda.  The  
>>> goto
>>> function (C-u C-c C-w) could possibly work the same way - now you  
>>> need
>>> to put the point on a task first - it won't work on the date or the
>>> Day-agenda line.
>>>
>>> This patch is available at git://git.norang.ca/org-mode for-carsten.
>>>
>>> lisp/org-agenda.el |   22 +++++++++++-----------
>>> 1 files changed, 11 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>>> index 073e668..83e8dd6 100644
>>> --- a/lisp/org-agenda.el
>>> +++ b/lisp/org-agenda.el
>>> @@ -5475,14 +5475,17 @@ If this information is not given, the
>>> function uses the tree at point."
>>> (defun org-agenda-refile (&optional goto rfloc)
>>>  "Refile the item at point."
>>>  (interactive "P")
>>> -  (let* ((marker (or (get-text-property (point) 'org-hd-marker)
>>> -		     (org-agenda-error)))
>>> -	 (buffer (marker-buffer marker))
>>> -	 (pos (marker-position marker))
>>> -	 (rfloc (or rfloc
>>> -		    (org-refile-get-location
>>> -		     (if goto "Goto: " "Refile to: ") buffer
>>> -		     org-refile-allow-creating-parent-nodes))))
>>> +  (if (equal goto '(16))
>>> +      (org-refile-goto-last-stored)
>>> +    (let* ((marker (or (get-text-property (point) 'org-hd-marker)
>>> +		       (org-agenda-error)))
>>> +	   (buffer (marker-buffer marker))
>>> +	   (pos (marker-position marker))
>>> +	   (rfloc))
>>> +      (setq rfloc (or rfloc
>>> +		      (org-refile-get-location
>>> +		       (if goto "Goto: " "Refile to: ") buffer
>>> +		       org-refile-allow-creating-parent-nodes))))
>>>    (with-current-buffer buffer
>>>      (save-excursion
>>> 	(save-restriction
>>> @@ -5491,9 +5494,6 @@ If this information is not given, the function
>>> uses the tree at point."
>>> 	  (org-remove-subtree-entries-from-agenda)
>>> 	  (org-refile goto buffer rfloc))))))
>>>
>>> -
>>> -
>>> -
>>> (defun org-agenda-open-link ()
>>>  "Follow the link in the current line, if any."
>>>  (interactive)
>>> -- 
>>> 1.6.4
>>>
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode