Re: [PATCH] Fix agenda bulk refile bug

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix agenda bulk refile bug
Date: Wed, 26 Aug 2009 16:49:28 +0200	[thread overview]
Message-ID: <36A91EF9-AD4F-4152-9C9A-5090A32FCF9E@gmail.com> (raw)
In-Reply-To: <1251297334-10504-1-git-send-email-bernt@norang.ca>

Applied, thanks.

- Carsten

On Aug 26, 2009, at 4:35 PM, Bernt Hansen wrote:

> Fix bulk refiling in the agenda due to commit
> 9ec5529 (Fix jumping to last refile location in agenda, 2009-08-20)
>
> This restores the original behaviour.
> ---
> This patch is available in git://git.norang.ca/org-mode for-carsten
>
> As it turns out the revert of the previous patch generated conflicts
> and I reverted it incorrectly :-P.  The following patch applied on top
> of master seems to fix the problem.
>
> Bernt
>
> lisp/org-agenda.el |   17 ++++++++---------
> 1 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 84d6566..d915e46 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -5481,18 +5481,17 @@ If this information is not given, the  
> function uses the tree at point."
> 		       (org-agenda-error)))
> 	   (buffer (marker-buffer marker))
> 	   (pos (marker-position marker))
> -	   (rfloc))
> -      (setq rfloc (or rfloc
> +	   (rfloc (or rfloc
> 		      (org-refile-get-location
> 		       (if goto "Goto: " "Refile to: ") buffer
> 		       org-refile-allow-creating-parent-nodes))))
> -    (with-current-buffer buffer
> -      (save-excursion
> -	(save-restriction
> -	  (widen)
> -	  (goto-char marker)
> -	  (org-remove-subtree-entries-from-agenda)
> -	  (org-refile goto buffer rfloc))))))
> +      (with-current-buffer buffer
> +	(save-excursion
> +	  (save-restriction
> +	    (widen)
> +	    (goto-char marker)
> +	    (org-remove-subtree-entries-from-agenda)
> +	    (org-refile goto buffer rfloc)))))))
>
> (defun org-agenda-open-link (&optional arg)
>   "Follow the link in the current line, if any.
> -- 
> 1.6.4.1.331.gda1d56
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode