From: Carsten Dominik <carsten.dominik@gmail.com>
To: Trevor Murphy <trevor.m.murphy@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] org.el: Don't flyspell check within source code blocks
Date: Sat, 1 Jun 2013 08:35:09 +0200 [thread overview]
Message-ID: <2D97D1EF-5906-4E52-B51D-C8AA3AF278FD@gmail.com> (raw)
In-Reply-To: <893F368F-3E66-4905-B51C-01C8CDCF1CE5@gmail.com>
On 1.6.2013, at 08:15, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> Hi Trevor,
>
> have you noticed an impact of this patch on normal typing performance?
> This is something we need to be extremely careful about.
Sorry, I see that Matt has already done some profiling. OK, I have applied this patch - lets see how it behaves.
- Carsten
>
> - Carsten
>
> On 30.5.2013, at 02:49, Trevor Murphy <trevor.m.murphy@gmail.com> wrote:
>
>> * lisp/org.el (org-mode-flyspell-verify): Add check for
>> `org-in-src-block-p'.
>>
>> TINYCHANGE
>> ---
>> lisp/org.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 94078f9..77de2d7 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -23596,7 +23596,8 @@ To get rid of the restriction, use \\[org-agenda-remove-restriction-lock]."
>> (not (member-ignore-case word (org-get-export-keywords)))
>> (not (member-ignore-case
>> word (mapcar 'car org-element-block-name-alist)))
>> - (not (member-ignore-case word '("BEGIN" "END" "ATTR"))))))
>> + (not (member-ignore-case word '("BEGIN" "END" "ATTR")))
>> + (not (org-in-src-block-p)))))
>>
>> (defun org-remove-flyspell-overlays-in (beg end)
>> "Remove flyspell overlays in region."
>> --
>> 1.8.3
>>
>>
>
prev parent reply other threads:[~2013-06-01 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 7:23 [PATCH] Take 2 on org.el: Don't flyspell check within source code blocks Trevor Murphy
2013-05-25 7:23 ` [PATCH] " Trevor Murphy
2013-05-25 15:52 ` Bastien
2013-05-30 0:55 ` Trevor Murphy
2013-05-30 15:54 ` Matt Lundin
2013-05-30 0:49 ` [PATCH v2] " Trevor Murphy
2013-06-01 6:15 ` Carsten Dominik
2013-06-01 6:35 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2D97D1EF-5906-4E52-B51D-C8AA3AF278FD@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=trevor.m.murphy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).