From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [PATCH v2] org.el: Don't flyspell check within source code
 blocks
Date: Sat, 1 Jun 2013 08:35:09 +0200
Message-ID: <2D97D1EF-5906-4E52-B51D-C8AA3AF278FD@gmail.com>
References: <1369466635-8217-1-git-send-email-trevor.m.murphy@gmail.com>
	<1369874995-24158-1-git-send-email-trevor.m.murphy@gmail.com>
	<893F368F-3E66-4905-B51C-01C8CDCF1CE5@gmail.com>
Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\))
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1UifPF-0002I0-NA
	for emacs-orgmode@gnu.org; Sat, 01 Jun 2013 02:35:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1UifPE-0004l6-Ss
	for emacs-orgmode@gnu.org; Sat, 01 Jun 2013 02:35:13 -0400
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:49964)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1UifPE-0004ks-My
	for emacs-orgmode@gnu.org; Sat, 01 Jun 2013 02:35:12 -0400
Received: by mail-wi0-f180.google.com with SMTP id hn14so1271430wib.7
	for <emacs-orgmode@gnu.org>; Fri, 31 May 2013 23:35:12 -0700 (PDT)
In-Reply-To: <893F368F-3E66-4905-B51C-01C8CDCF1CE5@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Trevor Murphy <trevor.m.murphy@gmail.com>
Cc: emacs-orgmode@gnu.org


On 1.6.2013, at 08:15, Carsten Dominik <carsten.dominik@gmail.com> =
wrote:

> Hi Trevor,
>=20
> have you noticed an impact of this patch on normal typing performance?
> This is something we need to be extremely careful about.

Sorry, I see that Matt has already done some profiling.  OK, I have =
applied this patch - lets see how it behaves.

- Carsten

>=20
> - Carsten
>=20
> On 30.5.2013, at 02:49, Trevor Murphy <trevor.m.murphy@gmail.com> =
wrote:
>=20
>> * lisp/org.el (org-mode-flyspell-verify): Add check for
>> `org-in-src-block-p'.
>>=20
>> TINYCHANGE
>> ---
>> lisp/org.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>=20
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 94078f9..77de2d7 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -23596,7 +23596,8 @@ To get rid of the restriction, use =
\\[org-agenda-remove-restriction-lock]."
>> 	 (not (member-ignore-case word (org-get-export-keywords)))
>> 	 (not (member-ignore-case
>> 	       word (mapcar 'car org-element-block-name-alist)))
>> -	 (not (member-ignore-case word '("BEGIN" "END" "ATTR"))))))
>> +	 (not (member-ignore-case word '("BEGIN" "END" "ATTR")))
>> +	 (not (org-in-src-block-p)))))
>>=20
>> (defun org-remove-flyspell-overlays-in (beg end)
>>  "Remove flyspell overlays in region."
>> --=20
>> 1.8.3
>>=20
>>=20
>=20