From: Carsten Dominik <carsten.dominik@gmail.com>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug in subtree narrowing
Date: Fri, 18 Sep 2009 07:22:44 +0100 [thread overview]
Message-ID: <27719CAA-BA26-4AAC-9DC0-9FF839B49945@gmail.com> (raw)
In-Reply-To: <20524da70909171609k269b816ev18d1a3f2560c7f76@mail.gmail.com>
On Sep 18, 2009, at 12:09 AM, Samuel Wales wrote:
> Hi Carsten,
>
> org-tree-to-indirect-buffer does not include the final
> newline. This causes sorting to run two lines together.
> For example, a headline can get joined to an :END: line.
> This can cause a task to not be recognized.
Fixed for this case.
>
> Sorting makes a lot of changes, so some users will not
> notice the bug until much later.
I do not understand what this has to do with narrowing to a subtree?
>
> org-narrow-to-subtree appears similar.
Fixed for this case as well.
>
> A lot of user code might assume, as perhaps org-sort does,
> that the final line has a newline.
>
> The choice of solution I will leave to you :).
>
> My preference is for the final newline to exist.
Are you suggesting that I should add the final newline?
Under what circumstances?
Are you aware of the variable `require-final-newline'? It might be
for you?
I have turned it on.
- Carsten
> This is
> because it feels normal to me as a user. If I go to the end
> of the buffer, then up, I usually expect to be on the last
> line. If I manually kill a subtree (or a paragraph) I kill
> to the beginning of the next line. m-x mark-paragraph
> appears to do this. So does m-x kill-paragraph.
>
> However, I will not file a bug on outline.
> outline-mark-subtree (which org users use also) does not include the
> final newline.
> outline-end-of-subtree does (forward-char -1), which means
> that it is deliberate. There are likely to be factors that
> I have not considered.
>
> "Org-mode version 6.30trans (release_6.30d.814.gdacd)" .
>
> Thanks.
>
>
> Samuel
>
>
> --
> Myalgic encephalomyelitis causes death (Jason et al. 2006)
> and severe suffering. Conflicts of interest are destroying
> research. What people "know" is wrong. Silence = death.
> http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2009-09-18 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 23:09 Bug in subtree narrowing Samuel Wales
2009-09-18 6:22 ` Carsten Dominik [this message]
2009-09-18 6:53 ` Samuel Wales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27719CAA-BA26-4AAC-9DC0-9FF839B49945@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=samologist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).