emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Samuel Wales <samologist@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Bug in subtree narrowing
Date: Thu, 17 Sep 2009 16:09:15 -0700	[thread overview]
Message-ID: <20524da70909171609k269b816ev18d1a3f2560c7f76@mail.gmail.com> (raw)

Hi Carsten,

org-tree-to-indirect-buffer does not include the final
newline.  This causes sorting to run two lines together.
For example, a headline can get joined to an :END: line.
This can cause a task to not be recognized.

Sorting makes a lot of changes, so some users will not
notice the bug until much later.

org-narrow-to-subtree appears similar.

A lot of user code might assume, as perhaps org-sort does,
that the final line has a newline.

The choice of solution I will leave to you :).

My preference is for the final newline to exist.  This is
because it feels normal to me as a user.  If I go to the end
of the buffer, then up, I usually expect to be on the last
line.  If I manually kill a subtree (or a paragraph) I kill
to the beginning of the next line.  m-x mark-paragraph
appears to do this.  So does m-x kill-paragraph.

However, I will not file a bug on outline.
outline-mark-subtree (which org users use also) does not include the
final newline.
outline-end-of-subtree does (forward-char -1), which means
that it is deliberate.  There are likely to be factors that
I have not considered.

"Org-mode version 6.30trans (release_6.30d.814.gdacd)" .

Thanks.


Samuel


-- 
Myalgic encephalomyelitis causes death (Jason et al. 2006)
and severe suffering.  Conflicts of interest are destroying
research.  What people "know" is wrong.  Silence = death.
http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

next             reply	other threads:[~2009-09-17 23:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17 23:09 Samuel Wales [this message]
2009-09-18  6:22 ` Bug in subtree narrowing Carsten Dominik
2009-09-18  6:53   ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20524da70909171609k269b816ev18d1a3f2560c7f76@mail.gmail.com \
    --to=samologist@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).