From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Wales Subject: Bug in subtree narrowing Date: Thu, 17 Sep 2009 16:09:15 -0700 Message-ID: <20524da70909171609k269b816ev18d1a3f2560c7f76@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoQ6M-0007zm-Ra for emacs-orgmode@gnu.org; Thu, 17 Sep 2009 19:09:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoQ6H-0007za-DO for emacs-orgmode@gnu.org; Thu, 17 Sep 2009 19:09:21 -0400 Received: from [199.232.76.173] (port=43371 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoQ6H-0007zX-7z for emacs-orgmode@gnu.org; Thu, 17 Sep 2009 19:09:17 -0400 Received: from mail-iw0-f198.google.com ([209.85.223.198]:42726) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoQ6G-0000MX-SD for emacs-orgmode@gnu.org; Thu, 17 Sep 2009 19:09:17 -0400 Received: by iwn36 with SMTP id 36so722089iwn.24 for ; Thu, 17 Sep 2009 16:09:15 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Carsten, org-tree-to-indirect-buffer does not include the final newline. This causes sorting to run two lines together. For example, a headline can get joined to an :END: line. This can cause a task to not be recognized. Sorting makes a lot of changes, so some users will not notice the bug until much later. org-narrow-to-subtree appears similar. A lot of user code might assume, as perhaps org-sort does, that the final line has a newline. The choice of solution I will leave to you :). My preference is for the final newline to exist. This is because it feels normal to me as a user. If I go to the end of the buffer, then up, I usually expect to be on the last line. If I manually kill a subtree (or a paragraph) I kill to the beginning of the next line. m-x mark-paragraph appears to do this. So does m-x kill-paragraph. However, I will not file a bug on outline. outline-mark-subtree (which org users use also) does not include the final newline. outline-end-of-subtree does (forward-char -1), which means that it is deliberate. There are likely to be factors that I have not considered. "Org-mode version 6.30trans (release_6.30d.814.gdacd)" . Thanks. Samuel -- Myalgic encephalomyelitis causes death (Jason et al. 2006) and severe suffering. Conflicts of interest are destroying research. What people "know" is wrong. Silence = death. http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm