From: Maxim Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-protocol: Fix missing '+' in js snippet
Date: Sun, 2 May 2021 18:34:54 +0700 [thread overview]
Message-ID: <25d5f9ca-e59c-184b-b941-3a2dcaa8af23@gmail.com> (raw)
In-Reply-To: <87v984b5kx.fsf@gnu.org>
On 30/04/2021 14:21, Bastien wrote:
> Maxim Nikulin writes:
>> On 28/04/2021 12:40, Bastien wrote:
>>>
>>> Would you like to volunteer as the maintainer for org-protocol.el?
>>> For now org-protocol.el indicates that Sebastian Rose, the original
>>> author, is the maintainer, but I don't think he would mind handing it
>>> to someone else.
Let me rise an issue related to org protocol that I consider important
enough. Test are not executed by default, so there is a chance that
breaking changes will be committed untested. There are two options:
1. Add org-protocol to the list of loaded packaged. The drawback is that
test run will not detect unintentional dependency of org core on
org-protocol.
2. Add a separate command to Makefile that tests exclusively
org-protocol and update testing/README with reminder concerning
org-protocol.
I believe that variant 2 is better, but opinion of core maintainers and
their workflow is certainly more important.
> ...
>> Example of my ignorance: I suspect, I did not recognize that
>> apostrophe needs special escaping in doc strings
>> https://orgmode.org/list/s4hsag$ogg$1@ciao.gmane.io/
By the way, the patch (I have updated it in meanwhile) is not tracked on
https://updates.orgmode.org/. I could not figure out what was the
difference from e.g.
https://orgmode.org/list/s6c1cm$174s$1@ciao.gmane.io/ Should I file an
issue at github?
>> Actually, I do not think, org-protocol requires a dedicated
>> maintainer. There are a few things that may be improved, but they
>> should be discussed at first. It seems, all current user already
>> managed to configure their handlers and prefer to not experiment any
>> more. So there is a little interest in this area.
>
> I don't use org-protocol.el myself and I'd rather have someone using
> it being able to reproduce bugs and help maintainers fix problems.
It is funny, but I am not an active org-protocol user as well. I tried
it, then I decided to create a browser extension that extracts some
metadata in addition to page title. Since I am not satisfied with
capture quality yet, I have to inspect page structure often enough. That
is why there is no point to minimize interaction (primary goal of
org-protocol) and I usually copy result and call org-paste-subtree.
Though I test from time to time that org-protocol is not broken in my
extension. The goal of my patches to org-protocol is to avoid some
surprises I have faced.
Since I use linux, I can not reproduce windows or mac problems.
Extrapolation of linux issues is not always applicable.
There were ~10 threads related to org protocol issues over 1.5 years I
have in local cache, so it is not a hot topic that deserves a
maintainer. Do not worry.
next prev parent reply other threads:[~2021-05-02 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:53 [PATCH] org-protocol: Fix missing '+' in js snippet David Asabina
2021-04-23 12:21 ` Maxim Nikulin
2021-04-28 5:40 ` Bastien
2021-04-28 12:42 ` Maxim Nikulin
2021-04-30 7:21 ` Bastien
2021-05-02 11:34 ` Maxim Nikulin [this message]
[not found] ` <20210503152514.bx5gghrqjr3vmxd7@bina>
[not found] ` <cd274ad0-488e-8b52-aef0-87a2e95c8b85@gmail.com>
2021-05-08 22:32 ` David Asabina
2021-04-28 5:38 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25d5f9ca-e59c-184b-b941-3a2dcaa8af23@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).