org-add-note not working with winner-mode

org-add-note not working with winner-mode

[Suvayu Ali]

Hi Orgers,

After updating org sometime in the last week I have been unable to run
org-add-note. Typing C-c C-z does nothing neither does explicitly
calling org-add-note. I have things setup to ask to add notes for
certain TODO state changes. Those don't work either. For the configured
TODOs, state changes only adds an empty LOGBOOK drawer without
prompting for any notes. All of these problems applies for the
corresponding agenda functions too (e.g. org-agenda-add-note).

I think the last HEAD where this combination (winner-mode turned
on) was working for me was the following commit:

commit 001346cbe7fb1824cd0d6fb84969f47778228cc8
Merge: 71e91e3 9010ae6
Author: Carsten Dominik <carsten.dominik@gmail.com>
Date:   Fri Mar 25 08:55:29 2011 +0100

    Merge branch 'master' of orgmode.org:org-mode

I am using GNU Emacs 24.0.50.1 (last updated sometime last week). Can
someone shed some light?

-- 
Suvayu

Open source is the future. It sets us free.

Re: org-add-note not working with winner-mode

[Bernt Hansen]

Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:

> After updating org sometime in the last week I have been unable to run
> org-add-note. Typing C-c C-z does nothing neither does explicitly
> calling org-add-note. I have things setup to ask to add notes for
> certain TODO state changes. Those don't work either. For the configured
> TODOs, state changes only adds an empty LOGBOOK drawer without
> prompting for any notes. All of these problems applies for the
> corresponding agenda functions too (e.g. org-agenda-add-note).
>
> I think the last HEAD where this combination (winner-mode turned
> on) was working for me was the following commit:
>
> commit 001346cbe7fb1824cd0d6fb84969f47778228cc8
> Merge: 71e91e3 9010ae6
> Author: Carsten Dominik <carsten.dominik@gmail.com>
> Date:   Fri Mar 25 08:55:29 2011 +0100
>
>     Merge branch 'master' of orgmode.org:org-mode
>
> I am using GNU Emacs 24.0.50.1 (last updated sometime last week). Can
> someone shed some light?

Hi Suvayu,

C-c C-z works for me (as does z in the agenda).  I've updated org-mode a
few minutes ago.  Can you verify this is broken for you with a minimal
emacs setup?  If not then something in your local configuration could be
the cause of this problem.

Org-mode version 7.5 (release_7.5-134-gb869b)
GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-12-11
on raven, modified by Debian

Regards,
Bernt

Re: org-add-note not working with winner-mode

[Suvayu Ali]

Hi Bernt,

On Sun, 03 Apr 2011 08:41:42 -0400
Bernt Hansen <bernt@norang.ca> wrote:

> Hi Suvayu,
> 
> C-c C-z works for me (as does z in the agenda).  I've updated
> org-mode a few minutes ago.  Can you verify this is broken for you
> with a minimal emacs setup?  If not then something in your local
> configuration could be the cause of this problem.
> 

I just updated, and I still have the same issue. I did a binary search
through my non-orgmode related Emacs setup, and it still comes down to
winner mode being turned on. When I start org with it turned off, it
works. But restarting emacs with it on or starting winner-mode by M-x
winner-mode while in org-mode brings back the problem.

> Org-mode version 7.5 (release_7.5-134-gb869b)
> GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of
> 2010-12-11 on raven, modified by Debian
> 

GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2011-03-29 on xxxxxxx.xxxxxxxxx.xxx
Org-mode version 7.5 (release_7.5.131.g15e86.dirty)

> Regards,
> Bernt

Thanks a lot,

-- 
Suvayu

Open source is the future. It sets us free.

Re: Re: org-add-note not working with winner-mode

[Nick Dokos]

Suvayu Ali <fatkasuvayu+linux@gmail.com> wrote:


> I just updated, and I still have the same issue. I did a binary search
> through my non-orgmode related Emacs setup, and it still comes down to
> winner mode being turned on. When I start org with it turned off, it
> works. But restarting emacs with it on or starting winner-mode by M-x
> winner-mode while in org-mode brings back the problem.
> 
> > Org-mode version 7.5 (release_7.5-134-gb869b)
> > GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of
> > 2010-12-11 on raven, modified by Debian
> > 
> 
> GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2011-03-29 on xxxxxxx.xxxxxxxxx.xxx
> Org-mode version 7.5 (release_7.5.131.g15e86.dirty)
> 

I replied earlier (just to Bernt - forgot to copy the list, sorry about
that) that I couldn't reproduce it either. I still cannot reproduce it
with the above instructions or with a minimal .emacs that just loads org
and turns on winner-mode. I can add notes to my heart's content.

Org-mode version 7.5 (release_7.5.127.gcd4ce)
GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2011-03-16

Nick

Re: Re: org-add-note not working with winner-mode

[Suvayu Ali]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Sun, 03 Apr 2011 17:12:01 -0400
Nick Dokos <nicholas.dokos@hp.com> wrote:

> I replied earlier (just to Bernt - forgot to copy the list, sorry
> about that) that I couldn't reproduce it either. I still cannot
> reproduce it with the above instructions or with a minimal .emacs
> that just loads org and turns on winner-mode. I can add notes to my
> heart's content.

I tried with the attached minimal test file and minimal setup. I still
have the issue with Emacs 24.0.50.1. I have tried running emacs like
this:

$ emacs -Q -l min.el testfile.org
$ emacs -nw -Q -l min.el testfile.org

However the problem vanishes with Emacs 23.2.1. Does this mean this is
an Emacs 24 problem?

-- 
Suvayu

Open source is the future. It sets us free.

[-- Attachment #2: testfile.org --]
[-- Type: text/plain, Size: 255 bytes --]


* DONE Some meeting
  DEADLINE: <2011-03-30 Wed 09:00> CLOSED: [2011-03-31 Thu 22:00]
  - Note taken on [2011-04-03 Sun 14:54] \\
    test note
  - Note taken on [2011-04-03 Sun 14:45] \\
    test note with winner-mode disabled

  Skype meeting

[-- Attachment #3: min.el --]
[-- Type: text/x-emacs-lisp, Size: 449 bytes --]

(setq debug-on-error t)
      ;; debug-on-signal t
      ;; debug-on-quit t)

(add-to-list 'load-path (expand-file-name "~/.emacs.d/lisp"))
(add-to-list 'load-path (expand-file-name "~/build/org-mode/lisp"))
(add-to-list 'load-path (expand-file-name "~/build/org-mode/contrib/lisp"))

(add-to-list 'Info-default-directory-list
	     (expand-file-name "/opt/emacs-lisp/share/info"))

(winner-mode t)

(require 'org-install)
(require 'org-inlinetask)

Re: Re: org-add-note not working with winner-mode

[Nick Dokos]

Suvayu Ali <fatkasuvayu+linux@gmail.com> wrote:

> On Sun, 03 Apr 2011 17:12:01 -0400
> Nick Dokos <nicholas.dokos@hp.com> wrote:
> 
> > I replied earlier (just to Bernt - forgot to copy the list, sorry
> > about that) that I couldn't reproduce it either. I still cannot
> > reproduce it with the above instructions or with a minimal .emacs
> > that just loads org and turns on winner-mode. I can add notes to my
> > heart's content.
> 
> I tried with the attached minimal test file and minimal setup. I still
> have the issue with Emacs 24.0.50.1. I have tried running emacs like
> this:
> 
> $ emacs -Q -l min.el testfile.org
> $ emacs -nw -Q -l min.el testfile.org
> 
> However the problem vanishes with Emacs 23.2.1. Does this mean this is
> an Emacs 24 problem?
> 

Mine was a fairly recent GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu,
GTK+ Version 2.22.0) of 2011-03-16. I think you'd be better off if you
tried debugging the org-add-note function using edebug.

Nick

Re: Re: org-add-note not working with winner-mode

[brian powell]

* http://www.emacswiki.org/emacs/WinnerMode gives:

"The problem with (windmove-default-keybindings) is that they clash
with the more common use on modern systems of S-right etc for
selecting text. In Emacs this is turned on by CuaMode for example.
Therefore it might be better to go with the alternative

(windmove-default-keybindings 'meta)

--ie suggest trying: (windmove-default-keybindings 'meta) rather than
(windmove-default-keybindings)

(I don't believe this will help; maybe though)

Re: Re: org-add-note not working with winner-mode

[Suvayu Ali]

Hi Brian,

On Mon, 4 Apr 2011 11:57:30 -0400
brian powell <briangpowellms@gmail.com> wrote:

> * http://www.emacswiki.org/emacs/WinnerMode gives:
> 

I am a little confused, aren't windmove and winner mode different
packages? I use both, but I narrowed down the problem to just
winner-mode.

> "The problem with (windmove-default-keybindings) is that they clash
> with the more common use on modern systems of S-right etc for
> selecting text. In Emacs this is turned on by CuaMode for example.
> Therefore it might be better to go with the alternative
> 
> (windmove-default-keybindings 'meta)
> 
> --ie suggest trying: (windmove-default-keybindings 'meta) rather than
> (windmove-default-keybindings)
> 
> (I don't believe this will help; maybe though)

I actually use windmove with meta, so no that doesn't help. I will
follow Nick's advice of using edebug on org-add-note when I can find the
time.

-- 
Suvayu

Open source is the future. It sets us free.

Re: Re: org-add-note not working with winner-mode

[Samuel Wales]

IIRC org-add-note works in a way that is unexpected.  I think it makes
its actions happen after the command itself.  I got bitten by that for
something else; maybe it is related here.

Samuel

-- 
The Kafka Pandemic:
  http://thekafkapandemic.blogspot.com/2010/12/welcome-to-kafka-pandemic-two-forces_9182.html
I support the Whittemore-Peterson Institute (WPI)
===
I want to see the original (pre-hold) Lo et al. 2010 NIH/FDA/Harvard MRV paper.

Re: org-add-note not working with winner-mode

[Suvayu Ali]

[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]

Hi Orgers,

I finally managed to get to this. I think the problem with winner mode
was a side-effect. The actual problem appears when you set to log
changes to TODO states and you attempt to make the changes from the
agenda. (Changing from the org buffer works fine)

On Mon, 4 Apr 2011 10:00:50 -0700
Samuel Wales <samologist@gmail.com> wrote:

> IIRC org-add-note works in a way that is unexpected.  I think it makes
> its actions happen after the command itself.  I got bitten by that for
> something else; maybe it is related here.
> 

From my observations it seems the above statement might be related to
the issue. I see that setting to record notes or TODO state changes like
this: "DONE(d@/!)", "DONE(d!)" or "DONE(d@)" triggers the problem. After
changing the TODO state from the agenda, org doesn't prompt me (in case
of @) or doesn't insert the time stamp (in case of !). However it does
write an empty LOGBOOK drawer. When I visit the headline subsequently by
hitting TAB from the agenda, I get prompted for the note or the
timestamp gets recorded as the case maybe for the particular keyword.

I have attached the minimal org setup I used to replicate this along
with an example org file. If I change more than one TODO states from the
agenda before visiting the org file, only the last TODO state change is
logged. For all the preceding changes, I only get an empty drawer.

As the last time, I don't see the problem when I am using Emacs 23.2. I
hope I have been able to explain the problem clearly this time.

Thanks,

-- 
Suvayu

Open source is the future. It sets us free.

[-- Attachment #2: test.org --]
[-- Type: text/plain, Size: 646 bytes --]


* DONE Debug TODO state change logging
  CLOSED: [2011-04-14 Thu 14:12]
  :LOGBOOK:
  - State "CONT"       from "TODO"       [2011-04-14 Thu 14:11]
  :END:

* DONE Write minimal org setup
  CLOSED: [2011-04-14 Thu 14:11]
  :LOGBOOK:
  - State "DONE"       from "TODO"       [2011-04-14 Thu 14:11] \\
    this is a note
  :END:

* DONE Write minimal demo file
  CLOSED: [2011-04-14 Thu 14:11]
  :LOGBOOK:
  :END:

* DONE Send email to list
  CLOSED: [2011-04-14 Thu 14:12]
  :LOGBOOK:
  - State "DONE"       from "CONT"       [2011-04-14 Thu 14:12]
  - State "CONT"       from "TODO"       [2011-04-14 Thu 14:12]
  :END:

[-- Attachment #3: min.el --]
[-- Type: text/x-emacs-lisp, Size: 997 bytes --]

(setq debug-on-error t
      debug-on-signal nil
      debug-on-quit nil)

(add-to-list 'load-path (expand-file-name "~/build/org-mode/lisp"))
(add-to-list 'load-path (expand-file-name "~/build/org-mode/contrib/lisp"))

(require 'org-install)
(require 'org-inlinetask)

(setq org-agenda-files '("~/org")
      ;; log time for TODO state changes
      org-log-done 'time
      ;; log time on rescheduling
      org-log-reschedule 'time
      ;; log time on changing deadline
      org-log-redeadline 'time
      ;; To put notes inside LOGBOOK drawer
      org-log-into-drawer t
      )

(setq org-todo-keywords
      '((sequence "TODO(t)" "DLAY(l@/!)" "CONT(c!)" "|" "DONE(d@/!)" "CNCL(n@/!)")
	))

(setq org-todo-keyword-faces
      '(("CNCL" . (:background "snow3" :foreground "black" :weight bold))
	))

(global-set-key (kbd "C-c a") 'org-agenda)
(global-set-key (kbd "C-c l") 'org-store-link)
(global-set-key (kbd "C-c C-l") 'org-insert-link-global)
(global-set-key (kbd "C-c b") 'org-switchb)

Re: org-add-note not working with winner-mode

[suvayu ali]

On Thu, Apr 14, 2011 at 2:27 PM, Suvayu Ali <fatkasuvayu+linux@gmail.com> wrote:
> I finally managed to get to this. I think the problem with winner mode
> was a side-effect. The actual problem appears when you set to log
> changes to TODO states and you attempt to make the changes from the
> agenda. (Changing from the org buffer works fine)
>

There is also an error like this sometimes. Not sure exactly when though.

Error in post-command-hook (org-add-log-note): (error Can't expand
minibuffer to full frame)

-- 
Suvayu

Open source is the future. It sets us free.