emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Robert Klein <roklein@roklein.de>
To: emacs-orgmode@gnu.org
Subject: Fix for ob-sqlite tests
Date: Sun, 9 Sep 2018 14:31:17 +0200	[thread overview]
Message-ID: <20180909143110.009a6e04@happy.intern.roklein.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Hi,

the tests for sqlite don't work because

1. the executable is sqlite3, not sqlite anymore for current software
(and obsqlite uses “sqlite3”, too)

2. the test doesn't have ob-sqlite loaded.


Please advice, if the “(require 'obsqlite)” is offensive.


Patch is attached.



Best regards
Robert

[-- Attachment #2: 0001-Fix-tests-for-sqlite.patch --]
[-- Type: text/x-patch, Size: 861 bytes --]

From c48a90b94bc7f0a86c7dd3b4747c893e64ec2e31 Mon Sep 17 00:00:00 2001
From: Robert Klein <roklein@roklein.de>
Date: Sun, 9 Sep 2018 14:27:20 +0200
Subject: [PATCH] Fix tests for sqlite

- sqlite executable used by ob-sqlite is 'sqlite3'
- require ob-sqlite for test
---
 testing/lisp/test-ob-sqlite.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/lisp/test-ob-sqlite.el b/testing/lisp/test-ob-sqlite.el
index f73251534..0cf68fabc 100644
--- a/testing/lisp/test-ob-sqlite.el
+++ b/testing/lisp/test-ob-sqlite.el
@@ -19,7 +19,8 @@
 ;; along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 ;;; Code:
-(org-test-for-executable "sqlite")
+(org-test-for-executable "sqlite3")
+(require 'ob-sqlite)
 (unless (featurep 'ob-sqlite)
   (signal 'missing-test-dependency "Support for sqlite code blocks"))
 
-- 
2.16.2


             reply	other threads:[~2018-09-09 12:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-09 12:31 Robert Klein [this message]
2018-09-13 21:06 ` Fix for ob-sqlite tests Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180909143110.009a6e04@happy.intern.roklein.de \
    --to=roklein@roklein.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).