From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Klein Subject: Fix for ob-sqlite tests Date: Sun, 9 Sep 2018 14:31:17 +0200 Message-ID: <20180909143110.009a6e04@happy.intern.roklein.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/ScYvBgdCw6hekaNPyPWI_3J" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:38398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyyvX-0007dn-91 for emacs-orgmode@gnu.org; Sun, 09 Sep 2018 08:34:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fyysF-0004cZ-BG for emacs-orgmode@gnu.org; Sun, 09 Sep 2018 08:31:35 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:42323) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fyysD-0004XH-5i for emacs-orgmode@gnu.org; Sun, 09 Sep 2018 08:31:30 -0400 Received: from happy.intern.roklein.de ([91.67.155.33]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MN5W7-1gFHMu2UK5-00J5aH for ; Sun, 09 Sep 2018 14:31:25 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --MP_/ScYvBgdCw6hekaNPyPWI_3J Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, the tests for sqlite don't work because 1. the executable is sqlite3, not sqlite anymore for current software (and obsqlite uses =E2=80=9Csqlite3=E2=80=9D, too) 2. the test doesn't have ob-sqlite loaded. Please advice, if the =E2=80=9C(require 'obsqlite)=E2=80=9D is offensive. Patch is attached. Best regards Robert --MP_/ScYvBgdCw6hekaNPyPWI_3J Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Fix-tests-for-sqlite.patch >From c48a90b94bc7f0a86c7dd3b4747c893e64ec2e31 Mon Sep 17 00:00:00 2001 From: Robert Klein Date: Sun, 9 Sep 2018 14:27:20 +0200 Subject: [PATCH] Fix tests for sqlite - sqlite executable used by ob-sqlite is 'sqlite3' - require ob-sqlite for test --- testing/lisp/test-ob-sqlite.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testing/lisp/test-ob-sqlite.el b/testing/lisp/test-ob-sqlite.el index f73251534..0cf68fabc 100644 --- a/testing/lisp/test-ob-sqlite.el +++ b/testing/lisp/test-ob-sqlite.el @@ -19,7 +19,8 @@ ;; along with this program. If not, see . ;;; Code: -(org-test-for-executable "sqlite") +(org-test-for-executable "sqlite3") +(require 'ob-sqlite) (unless (featurep 'ob-sqlite) (signal 'missing-test-dependency "Support for sqlite code blocks")) -- 2.16.2 --MP_/ScYvBgdCw6hekaNPyPWI_3J--