From: Rick Frankel <rick@rickster.com>
To: Oleh <ohwoeowho@gmail.com>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>,
org mode <emacs-orgmode@gnu.org>
Subject: Re: Drag images from Firefox to org-mode
Date: Fri, 18 Oct 2013 16:45:53 -0400 [thread overview]
Message-ID: <20131018204553.GA87254@BigDog.local> (raw)
In-Reply-To: <CAA01p3qtvu=tXuMKT4-P9xUSj4YF2MuGet68OV6ottzmvWDLXQ@mail.gmail.com>
On Fri, Oct 18, 2013 at 09:22:17PM +0200, Oleh wrote:
> Thanks, Rick and Nico, I've merged the code.
> All except the last bit from Rick: I can't think of any sensible
> way to enter an image URL except pasting it.
> And since link will be in the clipboard at some point, why not use
> it straight away without prompting.
> Maybe URL can be prompted for when called with a prefix arg,
> but I don't know how to do that yet.
I strongly disagree, for a couple of reasons:
- Esp. on non-unix systems, the contents of the cut-buffer are not
necessarily the same as the contents of the system clipboard. This
is the problem I was having w/ your code on windows, where the
cut-buffer contained the value of the current (or possibly last)
selection, but the clipboard had a url.
- It is certainly possible to type in a url
- You might want to DND a url from another buffer.
- It is ergonomically wrong for an interactive function defined to
take an argument (and called "download-image") to automagically use a
value from somewhere else and not actually take an argument.
It would however, make sense for the function to use the current
clipboard contents if called with a prefix.
In the same vein, I was thinking about the automagically creating a
subdirectory based on a top level heading. This is also wrong for a
couple reasons:
- Creating a potentially =very long directory name with spaces= can
cause multiple problems, both on unix and esp. non-unix systems,
where spaces may not be allowed in directory names, or there may be
limits on filename/directory length.
- The use of the top-level heading is arbitrary and may have nothing
to do with the current context (for instance, i sometimes group
together multiple documents to be output w/ export subtree in the
same master document)
The default should be to save it in the same directory as the document
(which by the way, may not be in emacs's idea of the current
directory). Also, the filename should not be expanded to an absolute
path, which makes the document non-portable and will break publishing.
If you want the ability to create arbitrary output directories based
on document context, the customization can be made to accept a
function (lambda) as a value, which could then return a directory
prefix.
While i realize the current implementation meets your needs, if the
code is to be included in the org-mode distribution it should follow
emacs and org conventions and not contains any suprises.
I would be glad to make the above changes on tuesday when i get back
to the office. Please send me (again) the url of the github repos with
the current set of changes and I will update it so that it will allow
the current functionality but have less magical default behavior.
rick
next prev parent reply other threads:[~2013-10-18 20:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 10:04 Drag images from Firefox to org-mode Oleh
2013-10-16 13:48 ` Torsten Wagner
2013-10-16 14:22 ` Xebar Saram
2013-10-16 15:52 ` Oleh
2013-10-16 17:28 ` Marcin Borkowski
2013-10-17 11:49 ` Samuel Loury
2013-10-17 3:42 ` Eric Abrahamsen
2013-10-17 12:04 ` Carsten Dominik
2013-10-17 12:43 ` Nicolas Richard
2013-10-17 14:04 ` Rick Frankel
2013-10-17 14:48 ` Nicolas Richard
2013-10-17 16:51 ` Rick Frankel
2013-10-18 5:29 ` Nicolas Richard
2013-10-18 14:44 ` Rick Frankel
2013-10-18 15:39 ` Nicolas Richard
2013-10-18 9:24 ` Oleh
2013-10-18 9:28 ` Carsten Dominik
2013-10-18 9:33 ` Oleh
2013-10-18 9:47 ` Nicolas Richard
2013-10-18 10:04 ` Oleh
2013-10-18 10:23 ` Nicolas Richard
[not found] ` <CAA01p3obTUXshcS-m=iB2KOADAx9eNpj8PK_F5O1x5dLtCobcA@mail.gmail.com>
2013-10-18 11:00 ` Nicolas Richard
2013-10-18 11:06 ` Oleh
2013-10-18 15:03 ` Rick Frankel
2013-10-18 15:36 ` Nicolas Richard
2013-10-18 15:44 ` Rick Frankel
2013-10-18 18:24 ` Rick Frankel
2013-10-18 19:22 ` Oleh
2013-10-18 20:45 ` Rick Frankel [this message]
2013-10-19 10:34 ` Oleh
2013-10-20 20:42 ` Nicolas Richard
2013-10-21 7:24 ` Oleh
2013-10-23 17:13 ` Rick Frankel
2013-10-23 18:26 ` Oleh
2013-10-23 18:59 ` Torsten Wagner
2013-10-23 20:01 ` Torsten Wagner
2013-10-24 6:47 ` Christian Moe
2014-01-04 15:01 ` Oleh
2014-01-04 15:17 ` Bastien
2013-10-18 10:44 ` Nicolas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018204553.GA87254@BigDog.local \
--to=rick@rickster.com \
--cc=emacs-orgmode@gnu.org \
--cc=ohwoeowho@gmail.com \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).