From: Oleh <ohwoeowho@gmail.com>
To: Rick Frankel <rick@rickster.com>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>,
org mode <emacs-orgmode@gnu.org>
Subject: Re: Drag images from Firefox to org-mode
Date: Wed, 23 Oct 2013 20:26:22 +0200 [thread overview]
Message-ID: <CAA01p3r4giP5ZVVBx1am2CaA8H=USg_HQESsu+W7bkF58BRGuA@mail.gmail.com> (raw)
In-Reply-To: <23f3f3530f88fa5571d80b8c38adf4c6@mail.rickster.com>
On Wed, Oct 23, 2013 at 7:13 PM, Rick Frankel <rick@rickster.com> wrote:
> On 2013-10-20 16:42, Nicolas Richard wrote:
>>
>> Oleh <ohwoeowho@gmail.com> writes:
>> This can be fixed with a platform-aware function that checks both the
>> clipboard and the cut-buffer.
>>
>> I suggest to ask for a string with (read-string "URL: " nil nil default),
>> offering the content of the clipboard/kill ring/selections as the DEFAULT.
>> I think it's better to be explicit when downloading content, and there
>> isn't much overhead in asking for a confirmation.
>
>
> Agreed. Downloading stuff to your local machine should require a
> confirmation step.
This is already in place.
>
>> This can be fixed by adding `org-download-max-filename-length`. When
>> it
>> overflows, just resort to `default-directory' and provide a
>> message/option to fix.
>>
>> I suggest that the right place for those files is as attachment, and
>> that's where customization should happen. The function choosing the
>> right place (i.e. org-download--dir) could be turned into a defvar or
>> defcustom which could then be set either to #'org-download--dir or
>> #'org-attach-dir.
>
>
> Agreed. Also, the current "fix" (two variable and three functions!) is
> overly complex.
Two variables can change independently in a meaningful way, giving
4 combinations with the possibility to alter just part of the setup on a file
local basis. Three functions specify the intent more clearly.
> I propose that their be three options in the
> defcustom:
> - 'org-attach-directory (the default)
> - user entered string
I don't get this one.
> - a function (which could be set to `org-download-dir')
This can be an option for `org-download-method'
>
>
>> By the way, which system doesn't allow for spaces in directory names?
>>
>> ISTR that MSDOS (except the latest versions) didn't allow spaces in
>> filenames :) Anyway, I tend to avoid spaces as much as I can in
>> filenames (including dirs)
>
>
> Also, sending files to external command/shell script for processing
> often breaks if you have spaces in paths due to quoting issue.
>
>
>> If you want the ability to create arbitrary output directories
>> based
>> on document context, the customization can be made to accept a
>> function (lambda) as a value, which could then return a directory
>> prefix.
>> This isn't an option for users with no elisp skills.
>>
>> It is an option if there are enough examples/built-ins that can be used.
>> e.g. message-send-mail-function can be customized in this way, its
>> docstring gives a list of meaningful values.
>
>
> Agreed.
There's still two functionality bits that I want to add:
local files and forwarding to default dnd handlers in the case it's
not an image.
But that can be added in later.
Please make the changes that you think are necessary and commit to org.
regards,
Oleh
next prev parent reply other threads:[~2013-10-23 18:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 10:04 Drag images from Firefox to org-mode Oleh
2013-10-16 13:48 ` Torsten Wagner
2013-10-16 14:22 ` Xebar Saram
2013-10-16 15:52 ` Oleh
2013-10-16 17:28 ` Marcin Borkowski
2013-10-17 11:49 ` Samuel Loury
2013-10-17 3:42 ` Eric Abrahamsen
2013-10-17 12:04 ` Carsten Dominik
2013-10-17 12:43 ` Nicolas Richard
2013-10-17 14:04 ` Rick Frankel
2013-10-17 14:48 ` Nicolas Richard
2013-10-17 16:51 ` Rick Frankel
2013-10-18 5:29 ` Nicolas Richard
2013-10-18 14:44 ` Rick Frankel
2013-10-18 15:39 ` Nicolas Richard
2013-10-18 9:24 ` Oleh
2013-10-18 9:28 ` Carsten Dominik
2013-10-18 9:33 ` Oleh
2013-10-18 9:47 ` Nicolas Richard
2013-10-18 10:04 ` Oleh
2013-10-18 10:23 ` Nicolas Richard
[not found] ` <CAA01p3obTUXshcS-m=iB2KOADAx9eNpj8PK_F5O1x5dLtCobcA@mail.gmail.com>
2013-10-18 11:00 ` Nicolas Richard
2013-10-18 11:06 ` Oleh
2013-10-18 15:03 ` Rick Frankel
2013-10-18 15:36 ` Nicolas Richard
2013-10-18 15:44 ` Rick Frankel
2013-10-18 18:24 ` Rick Frankel
2013-10-18 19:22 ` Oleh
2013-10-18 20:45 ` Rick Frankel
2013-10-19 10:34 ` Oleh
2013-10-20 20:42 ` Nicolas Richard
2013-10-21 7:24 ` Oleh
2013-10-23 17:13 ` Rick Frankel
2013-10-23 18:26 ` Oleh [this message]
2013-10-23 18:59 ` Torsten Wagner
2013-10-23 20:01 ` Torsten Wagner
2013-10-24 6:47 ` Christian Moe
2014-01-04 15:01 ` Oleh
2014-01-04 15:17 ` Bastien
2013-10-18 10:44 ` Nicolas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA01p3r4giP5ZVVBx1am2CaA8H=USg_HQESsu+W7bkF58BRGuA@mail.gmail.com' \
--to=ohwoeowho@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=rick@rickster.com \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).