Re: [PATCH] Improve configurability of ox-koma-letter

[Viktor Rosenfeld <listuser36@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Alan,

I've removed the defaults from OPENING and CLOSING. See the attached
patch.

Cheers,
Viktor

Alan Schmitt wrote:

> Viktor Rosenfeld writes:
> 
> > Rasmus also suggested setting the default opening and closing to nil
> > because we should not assume that everybody speaks English. Maybe, every
> > variable should default to nil.
> 
> Yes, I think it's a good idea. I often have lines that set the opening
> and closing to '~' to avoid having them.
> 
> Alan
> 

[-- Attachment #2: 0001-ox-koma-letter.el-No-default-opening-and-closing-lin.patch --]
[-- Type: text/plain, Size: 1286 bytes --]

From 1455bc78d87649ff2b41760f382c20fae4ecd585 Mon Sep 17 00:00:00 2001
From: Viktor Rosenfeld <listuser36@gmail.com>
Date: Sun, 5 May 2013 15:11:15 +0200
Subject: [PATCH 1/2] ox-koma-letter.el: No default opening and closing line.

	* ox-koma-letter.el (org-koma-letter-opening): No default / set to nil.
	(org-koma-letter-closing): No default / set to nil.

	We should not assume a formal English opening and closing
	line.  A letter requires many personal options, such as the
	address, so it is no more work to also these options.

TINYCHANGE
---
 contrib/lisp/ox-koma-letter.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/lisp/ox-koma-letter.el b/contrib/lisp/ox-koma-letter.el
index 31ccd89..37ff903 100644
--- a/contrib/lisp/ox-koma-letter.el
+++ b/contrib/lisp/ox-koma-letter.el
@@ -105,12 +105,12 @@
   :group 'org-export-koma-letter
   :type 'string)
 
-(defcustom org-koma-letter-opening "Dear Madam or Sir,"
+(defcustom org-koma-letter-opening nil
   "Letter's opening, as a string."
   :group 'org-export-koma-letter
   :type 'string)
 
-(defcustom org-koma-letter-closing "Sincerely yours,"
+(defcustom org-koma-letter-closing nil
   "Koma-Letter's closing, as a string."
   :group 'org-export-koma-letter
   :type 'string)
-- 
1.8.2.2