Re: [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode

[Toby Cubitt <tsc25@cantab.net>]

On Tue, Nov 06, 2012 at 06:30:47PM +0100, Nicolas Goaziou wrote:
> Toby Cubitt <tsc25@cantab.net> writes:
> 
> > I'm confused. Which variable are you talking about here?
> 
> `line-move-visual'
> 
> > Anyway, I see that `visual-line-mode's sets `line-move-visual' to t
> > buffer-locally. So checking only `line-move-visual' in
> > `org-beginning-of-line' is fine...
> >
> > ...which strongly suggests that the recent fix to `org-end-of-line' is
> > wrong. Shouldn't it also be checking `line-move-visual' and not
> > `visual-line-mode', like `org-beginning-of-line'?
> 
> Doesn't `visual-line-mode' set C-e to `end-of-visual-line'? As I tried
> to explain, unless I'm mistaken, `line-move-visual' has nothing to do
> with beginning or end of current line.

Aha! You may well be right. In which case why is `org-beginning-of-line'
doing this:

  (if (org-bound-and-true-p line-move-visual)
      (beginning-of-visual-line 1)
    (beginning-of-line 1))

Shouldn't it be doing this instead?

  (if (org-bound-and-true-p visual-line-mode)
      (beginning-of-visual-line 1)
    (beginning-of-line 1))

Or maybe I'm missing a subtle difference between org-beginning-of-line
and org-end-of-line...

Best,
Toby
-- 
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain

email: tsc25@cantab.net
web:   www.dr-qubit.org