emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode
Date: Tue, 06 Nov 2012 18:02:40 +0100	[thread overview]
Message-ID: <871ug68y1b.fsf@gmail.com> (raw)
In-Reply-To: <20121106124730.GA7699@c3po> (Toby Cubitt's message of "Tue, 6 Nov 2012 13:47:30 +0100")

Toby Cubitt <tsc25@cantab.net> writes:

> org-beginning-of-line uses org-beginning-of-visual-line when
> line-move-visual is enabled. I'm not sure if line-mode-visual can be
> disabled when visual-line-mode is enabled. If so, org-beginning-of-line
> should maybe test for either line-mode-visual *or* visual-line-mode.

`beginning-of-visual-line' either set locally `line-move-visual' to t or
use `vertical-motion', which doesn't care about `lime-move-visual'
value. Thus, as one could expect, `line-move-visual' has no effect on
horizontal scrolling.

IMO, checking this variable is a no-op.

Btw, if you plan to patch this area, could you provided tests for it
(see test-org/end-of-line in test-org.el)? As I can testify, there is
a high risk of regression in that area.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2012-11-06 17:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 12:30 [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode Toby Cubitt
2012-11-06 12:31 ` Nicolas Goaziou
2012-11-06 12:47   ` Toby Cubitt
2012-11-06 17:02     ` Nicolas Goaziou [this message]
2012-11-06 17:27       ` Toby Cubitt
2012-11-06 17:30         ` Nicolas Goaziou
2012-11-06 17:43           ` Toby Cubitt
2012-11-06 17:46             ` Nicolas Goaziou
2012-11-06 18:46               ` Toby Cubitt
2012-11-06 19:41                 ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ug68y1b.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).