From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode Date: Tue, 06 Nov 2012 18:02:40 +0100 Message-ID: <871ug68y1b.fsf@gmail.com> References: <87wqxy9aky.fsf@gmail.com> <20121106124730.GA7699@c3po> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVmcD-0000sR-7M for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:07:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVmc3-0004p8-OB for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:07:05 -0500 Received: from mail-wg0-f41.google.com ([74.125.82.41]:38605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVmc3-0004oz-Ds for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:06:55 -0500 Received: by mail-wg0-f41.google.com with SMTP id ds1so2396350wgb.0 for ; Tue, 06 Nov 2012 09:06:54 -0800 (PST) In-Reply-To: <20121106124730.GA7699@c3po> (Toby Cubitt's message of "Tue, 6 Nov 2012 13:47:30 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Toby Cubitt writes: > org-beginning-of-line uses org-beginning-of-visual-line when > line-move-visual is enabled. I'm not sure if line-mode-visual can be > disabled when visual-line-mode is enabled. If so, org-beginning-of-line > should maybe test for either line-mode-visual *or* visual-line-mode. `beginning-of-visual-line' either set locally `line-move-visual' to t or use `vertical-motion', which doesn't care about `lime-move-visual' value. Thus, as one could expect, `line-move-visual' has no effect on horizontal scrolling. IMO, checking this variable is a no-op. Btw, if you plan to patch this area, could you provided tests for it (see test-org/end-of-line in test-org.el)? As I can testify, there is a high risk of regression in that area. Regards, -- Nicolas Goaziou