[BUG] shell links broken

[BUG] shell links broken

[François Allisson]

Hello list,

Since last update of org this morning, I cannot open shell links any
longer. Instead, I get the message "void-variable
clean-buffer-list-kill-buffer-names" in the mini-buffer.

Commit 96551f3dd8885dee6972c70ce06888fd3d5f4dd4
(http://orgmode.org/w/?p=org-mode.git;a=commit;h=96551f3dd8885dee6972c70ce06888fd3d5f4dd4)
seems to be responsible. I don't understand the idea behind this huge
commit (I just started to read the elisp intro, since all my e-life is
in org now, it's time to start understanding the tool I use ;-)
hopefully I'll be more useful in some time for these kind of stuffs).

Anyway, below are potentially useful stuffs to reproduce the bug.

Best,
François


Versions:
Org-mode version 7.8.11 (release_7.8.11-366-g6f571d @ /usr/local/share/emacs/24.1.50/site-lisp/org/)
GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2012-08-02 on debian

-----*ecm.org*------------
* An eshell link
[[shell:echo 'Hello!'][My shell is polite.]]
----------------------------

-----*Backtrace*------
Debugger entered--Lisp error: (void-variable clean-buffer-list-kill-buffer-names)
  org-open-at-point(nil)
  call-interactively(org-open-at-point nil nil)
----------------------

-----*minimal-org.el*---------
(setq debug-on-error t
      debug-on-signal nil
      debug-on-quit nil)     
(add-to-list 'load-path (expand-file-name "/usr/local/share/emacs/24.1.50/site-lisp/org"))
(require 'org-install)
------------------------------

Re: [BUG] shell links broken

[Bastien]

Hi François,

François Allisson <francois@allisson.co> writes:

> Since last update of org this morning, I cannot open shell links any
> longer. Instead, I get the message "void-variable
> clean-buffer-list-kill-buffer-names" in the mini-buffer.

Fixed, thanks.

> Commit 96551f3dd8885dee6972c70ce06888fd3d5f4dd4
> (http://orgmode.org/w/?p=org-mode.git;a=commit;h=96551f3dd8885dee6972c70ce06888fd3d5f4dd4)
> seems to be responsible. I don't understand the idea behind this huge
> commit (I just started to read the elisp intro, since all my e-life is
> in org now, it's time to start understanding the tool I use ;-)
> hopefully I'll be more useful in some time for these kind of stuffs).

This is not from this commit.

> Anyway, below are potentially useful stuffs to reproduce the bug.

Thanks for the detailed recipe!

All best,

-- 
 Bastien

Re: [BUG] [PATCH] shell links broken

[François Allisson]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Hi Bastien

Le dimanche 05 aoû 2012 à 11:41:36 (+0200), Bastien a écrit :
> Hi François,
> 
> François Allisson <francois@allisson.co> writes:
> 
> > Since last update of org this morning, I cannot open shell links any
> > longer. Instead, I get the message "void-variable
> > clean-buffer-list-kill-buffer-names" in the mini-buffer.
> 
> Fixed, thanks.

Thanks! I confirm it works.

As I was pulling your latest fix, I noticed there was a little typo in
org.texi. I hope the attached patch will help fix it.

All the best,

François.

[-- Attachment #2: 0001-org.texi-Fix-typo.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From 7277580fd27d91c22e5dbc701af6862392c58a3e Mon Sep 17 00:00:00 2001
From: François Allisson <francois@allisson.co>
Date: Sun, 5 Aug 2012 14:07:10 +0200
Subject: [PATCH] org.texi: Fix typo

* doc/org.texi: Remove extra curly bracket.

TINYCHANGE
---
 doc/org.texi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/org.texi b/doc/org.texi
index 44aa362..3fdb4ac 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -5020,7 +5020,7 @@ TIMESTAMP_IA @r{The first inactive timestamp in the entry.}
 CLOCKSUM     @r{The sum of CLOCK intervals in the subtree.  @code{org-clock-sum}}
              @r{must be run first to compute the values in the current buffer.}
 CLOCKSUM_T   @r{The sum of CLOCK intervals in the subtree for today.}
-             @r{@code{org-clock-sum-today}} must be run first to compute the}
+             @r{@code{org-clock-sum-today} must be run first to compute the}
              @r{values in the current buffer.}
 BLOCKED      @r{"t" if task is currently blocked by children or siblings}
 ITEM         @r{The headline of the entry.}
-- 
1.7.10.4

Re: [BUG] [PATCH] shell links broken

[Bastien]

François Allisson <francois@allisson.co> writes:

> As I was pulling your latest fix, I noticed there was a little typo in
> org.texi. I hope the attached patch will help fix it.

Applied, thanks!

-- 
 Bastien