[Accepted] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

[Bastien Guerry <bzg@altern.org>]

Patch 587 (http://patchwork.newartisans.com/patch/587/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C87sjvzaezr.fsf%40keller.adm.naquadah.org%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda
> 	changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
> Date: Mon, 07 Feb 2011 16:39:17 -0000
> From: Julien Danjou <julien@danjou.info>
> X-Patchwork-Id: 587
> Message-Id: <87sjvzaezr.fsf@keller.adm.naquadah.org>
> To: Matt Lundin <mdl@imapmail.org>
> Cc: Bastien Guerry <bzg@altern.org>, emacs-orgmode@gnu.org
> 
> On Sat, Feb 05 2011, Matt Lundin wrote:
> 
> > This results in only a day view because org-agenda-current-span is still
> > 'day.
> 
> Here's a proposal fix.
> 
> I could have setq org-agenda-current-span to nil as a work around, but
> it seems more logical to just kill all the local variables. That is, a
> custom agenda view would not keep any of the local variable of the
> previous agenda, which seems logical to me.
> 
> 
> >From b48fc7c395dffea60df20c23b26e362ac0354b01 Mon Sep 17 00:00:00 2001
> From: Julien Danjou <julien@danjou.info>
> Date: Mon, 7 Feb 2011 12:36:42 +0100
> Subject: [PATCH] org-agenda: kill local variables in agenda view
> 
> * org-agenda.el (org-agenda): Kill all local variables. This
> assures we are not keeping buffer variable from an old agenda view
> when switching to a new custom agenda.
> 
> Signed-off-by: Julien Danjou <julien@danjou.info>
> ---
>  lisp/org-agenda.el |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index d146f83..9a3d953 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -2161,6 +2161,8 @@ Pressing `<' twice means to restrict to the current subtree or region
>        (put 'org-agenda-redo-command 'org-lprops nil)
>        ;; Remember where this call originated
>        (setq org-agenda-last-dispatch-buffer (current-buffer))
> +      ;; Remove all local variables
> +      (kill-all-local-variables)
>        (unless keys
>  	(setq ans (org-agenda-get-restriction-and-command prefix-descriptions)
>  	      keys (car ans)
> -- 
> 1.7.2.3
> 
>