From: Matt Lundin <mdl@imapmail.org>
To: Bastien Guerry <bzg@altern.org>, Julien Danjou <julien@danjou.info>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Date: Fri, 04 Feb 2011 20:20:34 -0500 [thread overview]
Message-ID: <87wrlfl1jx.fsf@fastmail.fm> (raw)
In-Reply-To: <20110201115210.6AD9A8783@myhost.localdomain> (Bastien Guerry's message of "Tue, 1 Feb 2011 12:52:10 +0100 (CET)")
Bastien Guerry <bzg@altern.org> writes:
> Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted".
>> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a
>> possible default span if it is set.
>>
>> Signed-off-by: Julien Danjou <julien@danjou.info>
>> ---
>> lisp/org-agenda.el | 5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index 0cd620c..0d695b5 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'."
>> (setq org-agenda-last-arguments (list include-all start-day span))
>> (org-compile-prefix-format 'agenda)
>> (org-set-sorting-strategy 'agenda)
>> - (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-agenda-span)))
>> + (let* ((span (org-agenda-ndays-to-span (or span
>> + org-agenda-current-span
>> + org-agenda-ndays
>> + org-agenda-span)))
>> (today (org-today))
>> (sd (or start-day today))
>> (ndays (org-agenda-span-to-ndays span sd))
>> --
This patch breaks custom commands --- i.e., if one binds org-agenda-span
in a custom command, it seems to be overridden by the span of whatever
agenda command one last called (i.e., org-agenda-current-span).
Steps to replicate:
1. (setq org-agenda-span 'day)
2. M-x org-agenda-list
3. Check the value of org-agenda-current-span => day
4. Call the following custom command:
(setq org-agenda-custom-commands
'(("c" "Calendar" agenda ""
((org-agenda-span 'week)
(org-agenda-start-on-weekday 0)
(org-agenda-time-grid nil)
(org-agenda-entry-types '(:timestamp :sexp))
(org-agenda-prefix-format " %-12:t ")
(org-deadline-warning-days 0)
(org-agenda-include-all-todo nil)
(org-agenda-repeating-timestamp-show-all t)
))))
This results in only a day view because org-agenda-current-span is still
'day.
Best,
Matt
next prev parent reply other threads:[~2011-02-05 1:20 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 4:09 Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Bernt Hansen
2010-12-22 7:03 ` Noorul Islam K M
2010-12-22 12:29 ` Bernt Hansen
2011-01-14 12:34 ` Carsten Dominik
2011-01-14 16:03 ` Bernt Hansen
2011-01-14 17:29 ` Carsten Dominik
2011-01-14 17:42 ` Bernt Hansen
2011-01-17 14:27 ` Bernt Hansen
2011-01-17 14:39 ` Carsten Dominik
2011-01-17 15:08 ` Julien Danjou
2011-01-17 16:34 ` Julien Danjou
2011-01-17 16:43 ` Carsten Dominik
2011-01-17 16:46 ` Julien Danjou
2011-01-18 9:43 ` Carsten Dominik
2011-01-18 10:00 ` Julien Danjou
2011-01-18 10:15 ` Carsten Dominik
2011-01-17 16:47 ` Bernt Hansen
2011-01-17 16:54 ` Julien Danjou
2011-01-17 17:00 ` Bernt Hansen
2011-01-17 17:04 ` Julien Danjou
2011-01-17 17:01 ` Carsten Dominik
2011-01-17 17:11 ` Julien Danjou
2011-01-17 17:14 ` Bernt Hansen
2011-01-17 18:27 ` [Accepted] " Bastien Guerry
2011-01-28 15:18 ` Julien Danjou
2011-01-28 15:43 ` Giovanni Ridolfi
2011-01-28 16:10 ` Julien Danjou
2011-02-01 11:52 ` Bastien
2011-02-01 11:52 ` [Accepted] " Bastien Guerry
2011-02-05 1:20 ` Matt Lundin [this message]
2011-02-05 8:56 ` Julien Danjou
2011-02-07 11:39 ` Julien Danjou
2011-02-08 17:05 ` [Accepted] " Bastien Guerry
2011-02-09 16:37 ` Bastien
2011-02-10 9:20 ` Carsten Dominik
2011-02-10 10:51 ` Julien Danjou
2011-02-10 11:50 ` Carsten Dominik
2011-02-10 12:00 ` Julien Danjou
2011-02-10 14:35 ` Bastien
2011-02-10 21:21 ` Michael Brand
2011-02-17 13:57 ` Carsten Dominik
2011-02-17 14:43 ` Bastien
2011-02-18 14:19 ` Bastien
2011-02-18 14:46 ` Gábor Melis
2011-02-18 16:42 ` Carsten Dominik
2011-02-19 9:36 ` Bastien
2011-02-10 11:18 ` Michael Brand
2011-02-10 11:55 ` Carsten Dominik
2011-02-24 14:38 ` Matt Lundin
2011-02-24 15:01 ` Matt Lundin
2011-02-25 0:11 ` Bastien
2011-02-25 0:15 ` Bastien
2011-03-06 15:40 ` Bastien
2011-03-06 16:47 ` Michael Brand
2011-03-06 17:15 ` Bastien
2011-03-06 18:26 ` Michael Brand
2011-03-06 18:35 ` Bastien
2011-03-07 18:26 ` Matt Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrlfl1jx.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=julien@danjou.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).