From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Date: Mon, 17 Jan 2011 19:27:16 +0100 (CET) [thread overview]
Message-ID: <20110117182717.006CB46626@myhost.localdomain> (raw)
In-Reply-To: sa3mxmzv4k0.fsf@cigue.easter-eggs.fr
Patch 544 (http://patchwork.newartisans.com/patch/544/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3Csa3mxmzv4k0.fsf%40cigue.easter-eggs.fr%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: Bug: Jumping to a date in the agenda changes view back
> to 'day' [7.4 (release_7.4.80.g0e5e5)]
> Date: Mon, 17 Jan 2011 22:11:11 -0000
> From: Julien Danjou <julien@danjou.info>
> X-Patchwork-Id: 544
> Message-Id: <sa3mxmzv4k0.fsf@cigue.easter-eggs.fr>
> To: Bernt Hansen <bernt@norang.ca>
> Cc: Org Mode <emacs-orgmode@gnu.org>, Noorul Islam K M <noorul@noorul.com>,
> Carsten Dominik <carsten.dominik@gmail.com>
>
> On Mon, Jan 17 2011, Bernt Hansen wrote:
> >
> > Thanks for this patch. I think this fixes the issue I was having with
> > 'j' in the agenda switching from week-view back to single-day view when
> > org-agenda-ndays is set to 1.
> >
> > There is still a (new?) problem with jumping to today.
> >
> > Set the following variable
> >
> > (setq org-agenda-start-on-weekday 6)
> >
> > | Key Sequence | Notes |
> > |--------------+------------------------------------------------|
> > | C-c a a | Display weekly agenda |
> > | f | Go forward a week |
> > | d | Display day agenda |
> > | . | Go to to day - but it goes to Saturday instead |
> >
> > This should go to today and not the first day of the week.
>
> Attached is a fix for that.
>
>
> >From f566a5612560f997f4760144ca850dda5c06bc5e Mon Sep 17 00:00:00 2001
> From: Julien Danjou <julien@danjou.info>
> Date: Mon, 17 Jan 2011 18:09:30 +0100
> Subject: [PATCH] Fix org-agenda-goto-today not respecting the current span.
>
> * org-agenda.el (org-agenda-goto-today): Respect current span.
>
> Signed-off-by: Julien Danjou <julien@danjou.info>
> ---
> lisp/org-agenda.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 0d695b5..241ed30 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -6104,7 +6104,7 @@ Negative selection means regexp must not match for selection of an entry."
> (tdpos (goto-char tdpos))
> ((eq org-agenda-type 'agenda)
> (let* ((sd (org-agenda-compute-starting-span
> - (org-today) (or org-agenda-ndays org-agenda-span)))
> + (org-today) (or org-agenda-current-span org-agenda-ndays org-agenda-span)))
> (org-agenda-overriding-arguments org-agenda-last-arguments))
> (setf (nth 1 org-agenda-overriding-arguments) sd)
> (org-agenda-redo)
> --
> 1.7.2.3
>
>
next prev parent reply other threads:[~2011-01-17 18:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 4:09 Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Bernt Hansen
2010-12-22 7:03 ` Noorul Islam K M
2010-12-22 12:29 ` Bernt Hansen
2011-01-14 12:34 ` Carsten Dominik
2011-01-14 16:03 ` Bernt Hansen
2011-01-14 17:29 ` Carsten Dominik
2011-01-14 17:42 ` Bernt Hansen
2011-01-17 14:27 ` Bernt Hansen
2011-01-17 14:39 ` Carsten Dominik
2011-01-17 15:08 ` Julien Danjou
2011-01-17 16:34 ` Julien Danjou
2011-01-17 16:43 ` Carsten Dominik
2011-01-17 16:46 ` Julien Danjou
2011-01-18 9:43 ` Carsten Dominik
2011-01-18 10:00 ` Julien Danjou
2011-01-18 10:15 ` Carsten Dominik
2011-01-17 16:47 ` Bernt Hansen
2011-01-17 16:54 ` Julien Danjou
2011-01-17 17:00 ` Bernt Hansen
2011-01-17 17:04 ` Julien Danjou
2011-01-17 17:01 ` Carsten Dominik
2011-01-17 17:11 ` Julien Danjou
2011-01-17 17:14 ` Bernt Hansen
2011-01-17 18:27 ` Bastien Guerry [this message]
2011-01-28 15:18 ` Julien Danjou
2011-01-28 15:43 ` Giovanni Ridolfi
2011-01-28 16:10 ` Julien Danjou
2011-02-01 11:52 ` Bastien
2011-02-01 11:52 ` [Accepted] " Bastien Guerry
2011-02-05 1:20 ` Matt Lundin
2011-02-05 8:56 ` Julien Danjou
2011-02-07 11:39 ` Julien Danjou
2011-02-08 17:05 ` [Accepted] " Bastien Guerry
2011-02-09 16:37 ` Bastien
2011-02-10 9:20 ` Carsten Dominik
2011-02-10 10:51 ` Julien Danjou
2011-02-10 11:50 ` Carsten Dominik
2011-02-10 12:00 ` Julien Danjou
2011-02-10 14:35 ` Bastien
2011-02-10 21:21 ` Michael Brand
2011-02-17 13:57 ` Carsten Dominik
2011-02-17 14:43 ` Bastien
2011-02-18 14:19 ` Bastien
2011-02-18 14:46 ` Gábor Melis
2011-02-18 16:42 ` Carsten Dominik
2011-02-19 9:36 ` Bastien
2011-02-10 11:18 ` Michael Brand
2011-02-10 11:55 ` Carsten Dominik
2011-02-24 14:38 ` Matt Lundin
2011-02-24 15:01 ` Matt Lundin
2011-02-25 0:11 ` Bastien
2011-02-25 0:15 ` Bastien
2011-03-06 15:40 ` Bastien
2011-03-06 16:47 ` Michael Brand
2011-03-06 17:15 ` Bastien
2011-03-06 18:26 ` Michael Brand
2011-03-06 18:35 ` Bastien
2011-03-07 18:26 ` Matt Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117182717.006CB46626@myhost.localdomain \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).