From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Re: In-buffer completion
Date: Tue, 23 Nov 2010 15:12:13 +0100 (CET) [thread overview]
Message-ID: <20101123141213.8F726762995@carsten-dominiks-macbook-pro.local> (raw)
In-Reply-To: 874obblwa8.fsf@gmail.com
Patch 396 (http://patchwork.newartisans.com/patch/396/) is now "Accepted".
Maintainer comment: No comment
This relates to the following submission:
http://mid.gmane.org/%3C874obblwa8.fsf%40gmail.com%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: In-buffer completion
> Date: Sat, 20 Nov 2010 22:50:07 -0000
> From: Dan Davison <dandavison7@gmail.com>
> X-Patchwork-Id: 396
> Message-Id: <874obblwa8.fsf@gmail.com>
> To: Carsten Dominik <carsten.dominik@gmail.com>
> Cc: John Wiegley <jwiegley@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
> > Dear all,
> >
> > yesterday I replaced the previous implementation of
> > in-buffer completion (M-TAB of Esc TAB) with a new
> > function making use of John Wiegleys pcomplete.el.
> > In fact, John did most of the Org-related implementation
> > already months ago - I only tied up some loose ends.
> >
> > So if you are noticing something unexpected in
> > in-buffer completion, this is the cause. There may
> > be bugs, if you find any, let me know.
> >
> > Most importantly, however, in-buffer completion is now
> > implement so much cleaner, and we can extend it if we
> > want. So if you have good ideas where in-buffer completion
> > would be useful and does not work already, lets hear it!
>
> Hi Carsten,
>
> That looks nice. Here's a few #+ keywords I notice are
> missing. (Shouldn't more of these entries have a terminal colon?)
>
> Dan
>
>
>
> >
> > Thanks to John for yet another great addition to Org mode.
> >
> > - Carsten
> >
> > _______________________________________________
> > Emacs-orgmode mailing list
> > Please use `Reply All' to send replies to the list.
> > Emacs-orgmode@gnu.org
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index c634a6c..917a368 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10547,9 +10547,14 @@ This function can be used in a hook."
> "BEGIN_VERSE" "END_VERSE"
> "BEGIN_CENTER" "END_CENTER"
> "BEGIN_SRC" "END_SRC"
> + "SOURCE:" "SRCNAME:" "FUNCTION:"
> + "RESULTS:"
> + "HEADER:" "HEADERS:"
> + "BABEL:"
> "CATEGORY" "COLUMNS" "PROPERTY"
> "CAPTION" "LABEL"
> "SETUPFILE"
> + "INCLUDE:"
> "BIND"
> "MACRO"))
>
>
next prev parent reply other threads:[~2010-11-23 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 14:26 In-buffer completion Carsten Dominik
2010-11-20 17:50 ` Dan Davison
2010-11-20 19:16 ` Carsten Dominik
2010-11-23 14:12 ` Carsten Dominik [this message]
2010-11-25 21:35 ` [Accepted] " Dan Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123141213.8F726762995@carsten-dominiks-macbook-pro.local \
--to=cdominik@newartisans.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).