emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tyler Smith <tyler@plantarum.ca>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Emacs Org-Mode Help <emacs-orgmode@gnu.org>
Subject: Re: org-capture quitting and make-capture-frame
Date: Mon, 23 Oct 2017 16:41:47 -0400	[thread overview]
Message-ID: <1508791307.1042871.1148450728.33D4D6F3@webmail.messagingengine.com> (raw)
In-Reply-To: <87wp3lr5ro.fsf@nicolasgoaziou.fr>

On Mon, Oct 23, 2017, at 04:03 PM, Nicolas Goaziou wrote:
> 
> Wouldn't it make more sense to turn it into 
> 
>  (message "Abort")
> 
> ? After all, it is not an error. It also allow to call other functions,
> e.g., `delete-frame' after exiting capture.
> 
> WDYT?
> 

I did think it was odd that this called an error, as it isn't an error
at all. 

I'm not sure how calling `(message ...)` at that point would enable
calling `delete-frame` after exiting capture? At the moment I'm calling
`delete` frame it by advising org-capture-destroy and
org-capture-finalize. I don't think either are called when you quit out
of the template selection dialog. Quitting needs to do something that
you can respond to, either with a hook, an advised function or something
else?

My proposal was just the first thing that I thought of, I'm sure there
are better solutions. That could be (message ...), but I'm missing
something in that case.

Best,

Tyler

  reply	other threads:[~2017-10-23 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 14:59 org-capture quitting and make-capture-frame Tyler Smith
2017-10-23 20:03 ` Nicolas Goaziou
2017-10-23 20:41   ` Tyler Smith [this message]
2017-10-23 21:11     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508791307.1042871.1148450728.33D4D6F3@webmail.messagingengine.com \
    --to=tyler@plantarum.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).