emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Tyler Smith <tyler@plantarum.ca>
To: Emacs Org-Mode Help <emacs-orgmode@gnu.org>
Subject: org-capture quitting and make-capture-frame
Date: Mon, 23 Oct 2017 10:59:37 -0400	[thread overview]
Message-ID: <1508770777.115397.1148043056.71AE2BBC@webmail.messagingengine.com> (raw)

Hi,

I use org-capture with a new frame, so I can call it quickly when from
the OS (see
http://www.windley.com/archives/2010/12/capture_mode_and_emacs.shtml).

This works well, except that if I quit a capture, the frame is left
hanging. I looked through the code, and this is due to org-capture
calling `(user-error "Abort")` in response to my entering 'q' to
indicate I want to cancel my capture. 

It would be nice to allow for some configuration here. In my case, I
have replaced this line:

    ((equal entry "q")
	    (user-error "Abort"))

(source:
http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el?h=emacs-sync#n632
)

with

    ((equal entry "q")
       (if (equal "capture" (frame-parameter nil 'name))  
           (delete-frame))

That will work for my use case, until org-mode is updated at least.
Would it be possible to do something like this instead:

    ((equal entry "q")
      (funcall org-capture-quite-function))

That would allow you to provide a sensible default, such as '(user-error
"Abort")', while allowing users to tweak this behaviour, as needed for
cleaning up capture frames.

I've pasted the additional functions I'm using below, FYI.

Best,

Tyler

(defun make-capture-frame ()  
  "Create a new frame and run org-capture."  
  (interactive)  
  (select-frame-set-input-focus
   (make-frame '((name . "capture") 
                 (width . 120) 
                 (height . 15))))  
  (setq word-wrap 1)
  (setq truncate-lines nil)
  (org-capture))

(defadvice org-switch-to-buffer-other-window 
  (after supress-window-splitting activate)  
  "Delete the extra window if we're in a capture frame"  
  (if (equal "capture" (frame-parameter nil 'name))  
      (delete-other-windows)))

(defadvice org-capture-destroy 
    (after delete-capture-frame activate)  
  "Advise capture-destroy to close the frame"  
  (if (equal "capture" (frame-parameter nil 'name))  
      (delete-frame)))

(defadvice org-capture-finalize 
    (after delete-capture-frame activate)  
  "Advise capture-finalize to close the frame"  
  (if (equal "capture" (frame-parameter nil 'name))  
      (delete-frame)))
 

-- 
plantarum.ca

next             reply	other threads:[~2017-10-23 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 14:59 Tyler Smith [this message]
2017-10-23 20:03 ` org-capture quitting and make-capture-frame Nicolas Goaziou
2017-10-23 20:41   ` Tyler Smith
2017-10-23 21:11     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508770777.115397.1148043056.71AE2BBC@webmail.messagingengine.com \
    --to=tyler@plantarum.ca \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).