emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH 1/2] Fix docstring for org-export-html-{pre, post}amble
@ 2010-05-21 15:21 Julien Danjou
  2010-05-21 15:21 ` [PATCH 2/2] Do not expand title in <title> markups Julien Danjou
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Danjou @ 2010-05-21 15:21 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Julien Danjou

Signed-off-by: Julien Danjou <julien@danjou.info>
---

I had a hard time figuring out how it works, and after reading the source
code, I think the docstring is wrong.

 lisp/org-html.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-html.el b/lisp/org-html.el
index d5f4775..e7064ab 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -405,10 +405,10 @@ with a link to this URL."
 ;;; Variables, constants, and parameter plists
 
 (defvar org-export-html-preamble nil
-  "Preamble, to be inserted just before <body>.  Set by publishing functions.
+  "Preamble, to be inserted just after <body>.  Set by publishing functions.
 This may also be a function, building and inserting the preamble.")
 (defvar org-export-html-postamble nil
-  "Preamble, to be inserted just after </body>.  Set by publishing functions.
+  "Preamble, to be inserted just before </body>.  Set by publishing functions.
 This may also be a function, building and inserting the postamble.")
 (defvar org-export-html-auto-preamble t
   "Should default preamble be inserted?  Set by publishing functions.")
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 2/2] Do not expand title in <title> markups
  2010-05-21 15:21 [PATCH 1/2] Fix docstring for org-export-html-{pre, post}amble Julien Danjou
@ 2010-05-21 15:21 ` Julien Danjou
  0 siblings, 0 replies; 2+ messages in thread
From: Julien Danjou @ 2010-05-21 15:21 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Julien Danjou

If we expand `title', we may have HTML markup between the <title>
markups, which is not valid.

Signed-off-by: Julien Danjou <julien@danjou.info>
---
 lisp/org-html.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-html.el b/lisp/org-html.el
index e7064ab..9a744cf 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -913,7 +913,7 @@ lang=\"%s\" xml:lang=\"%s\">
 		      "")
 		  (or charset "iso-8859-1"))
 		 language language
-		 (org-html-expand title)
+		 title
 		 (or charset "iso-8859-1")
 		 date author description keywords
 		 style
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-21 15:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-21 15:21 [PATCH 1/2] Fix docstring for org-export-html-{pre, post}amble Julien Danjou
2010-05-21 15:21 ` [PATCH 2/2] Do not expand title in <title> markups Julien Danjou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).