lists and fill-region

lists and fill-region

[michael hohn]

Hi all,

after upgrading to the current git head (from a version around 6.36),
fill-region produces wrong indentation for my lists.  Starting with

- one
  - very, very, very, very, very, very, very, very, very, very, very, very, long
  - short

and marking the second item via mark-paragraph followed by fill-region
results in

- one
  - very, very, very, very, very, very, very, very, very, very, very,
very, long
  - short

I have tried different settings for org-list-ending-method but this
doesn't change the result.

Has anybody seen this or know a fix?

Thank you,
Michael

Re: lists and fill-region

[Matt Lundin]

michael hohn <mhhohn@gmail.com> writes:

> Hi all,
>
> after upgrading to the current git head (from a version around 6.36),
> fill-region produces wrong indentation for my lists.  Starting with
>
> - one
>   - very, very, very, very, very, very, very, very, very, very, very, very, long
>   - short
>
> and marking the second item via mark-paragraph followed by fill-region
> results in
>
> - one
>   - very, very, very, very, very, very, very, very, very, very, very,
> very, long
>   - short

I can reproduce this. It occurs only when marking a region, not when
calling fill paragraph directly on the item.

A related bug: 

> - one
>   - very, very, very, very, very, very, very, very, very, very, very,
> very, long
>   - short

If one calls unfill-paragraph on the "very, very" line above, nothing
happens. In the past, unfill paragraph would turn the item into a single
line, which is very convenient for fixing improperly indented multi-line
items.

Best,
Matt

Re: lists and fill-region

[Nicolas]

Hello,

Matt Lundin <mdl@imapmail.org> writes:

> A related bug: 
>
>> - one
>>   - very, very, very, very, very, very, very, very, very, very, very,
>> very, long
>>   - short
>
> If one calls unfill-paragraph on the "very, very" line above, nothing
> happens. In the past, unfill paragraph would turn the item into a single
> line, which is very convenient for fixing improperly indented multi-line
> items.

Could you tell me if the problem with unfill-paragraph persists?  If it
does, as there is no unfill-paragraph in standard Emacs, could you
provide the definition you gave it?

Thanks.

Regards,

-- 
Nicolas

Re: lists and fill-region

[Matt Lundin]

Nicolas <n.goaziou@gmail.com> writes:

> Hello,
>
> Matt Lundin <mdl@imapmail.org> writes:
>
>> A related bug: 
>>
>>> - one
>>>   - very, very, very, very, very, very, very, very, very, very, very,
>>> very, long
>>>   - short
>>
>> If one calls unfill-paragraph on the "very, very" line above, nothing
>> happens. In the past, unfill paragraph would turn the item into a single
>> line, which is very convenient for fixing improperly indented multi-line
>> items.
>
> Could you tell me if the problem with unfill-paragraph persists?  

The problem is solved in the most recent git. Thanks!

> If it does, as there is no unfill-paragraph in standard Emacs, could
> you provide the definition you gave it?

You are right. Sometimes it is difficult to remember where Emacs begins
and one's own customizations end. :)

Here is unfill-paragraph (grabbed from the emacswiki, I believe):

--8<---------------cut here---------------start------------->8---
(defun unfill-paragraph ()
  (interactive)
  (let ((fill-column (point-max)))
    (fill-paragraph nil)))
--8<---------------cut here---------------end--------------->8---

Thanks again,
Matt

Re: lists and fill-region

[Bernt Hansen]

michael hohn <mhhohn@gmail.com> writes:

> Hi all,
>
> after upgrading to the current git head (from a version around 6.36),
> fill-region produces wrong indentation for my lists.  Starting with
>
> - one
>   - very, very, very, very, very, very, very, very, very, very, very, very, long
>   - short
>
> and marking the second item via mark-paragraph followed by fill-region
> results in
>
> - one
>   - very, very, very, very, very, very, very, very, very, very, very,
> very, long
>   - short
>
> I have tried different settings for org-list-ending-method but this
> doesn't change the result.
>
> Has anybody seen this or know a fix?

Hi Michael,

This wraps okay for me.  I get the following:

--8<---------------cut here---------------start------------->8---
- one
  - very, very, very, very, very, very, very, very, very, very, very,
    very, long
  - short
--8<---------------cut here---------------end--------------->8---

Have you tried it with a minimal emacs setup?  Maybe it's something in
your customizations that affects this.

Regards,
-- 
Bernt

Re: lists and fill-region

[Nick Dokos]

Bernt Hansen <bernt@norang.ca> wrote:

> michael hohn <mhhohn@gmail.com> writes:
> 
> > Hi all,
> >
> > after upgrading to the current git head (from a version around 6.36),
> > fill-region produces wrong indentation for my lists.  Starting with
> >
> > - one
> >   - very, very, very, very, very, very, very, very, very, very, very, very, long
> >   - short
> >
> > and marking the second item via mark-paragraph followed by fill-region
> > results in
> >
> > - one
> >   - very, very, very, very, very, very, very, very, very, very, very,
> > very, long
> >   - short
> >
> > I have tried different settings for org-list-ending-method but this
> > doesn't change the result.
> >
> > Has anybody seen this or know a fix?
> 
> Hi Michael,
> 
> This wraps okay for me.  I get the following:
> 
> - one
>   - very, very, very, very, very, very, very, very, very, very, very,
>     very, long
>   - short
> 
> Have you tried it with a minimal emacs setup?  Maybe it's something in
> your customizations that affects this.
> 

With fill-paragraph, I get what Bernt gets. With
mark-paragraph/fill-region, I get what Michael gets. This is with emacs
-q -l minimal.emacs. In both cases, I start with point at the beginning
of the very, very long line.

Org-mode version 7.5 (release_7.5.7.g4090.dirty)
GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2010-11-17 on alphaville

Nick

Re: lists and fill-region

[Bernt Hansen]

Nick Dokos <nicholas.dokos@hp.com> writes:

> Bernt Hansen <bernt@norang.ca> wrote:
>
>> michael hohn <mhhohn@gmail.com> writes:
>> 
>> > Hi all,
>> >
>> > after upgrading to the current git head (from a version around 6.36),
>> > fill-region produces wrong indentation for my lists.  Starting with
>> >
>> > - one
>> >   - very, very, very, very, very, very, very, very, very, very, very, very, long
>> >   - short
>> >
>> > and marking the second item via mark-paragraph followed by fill-region
>> > results in
>> >
>> > - one
>> >   - very, very, very, very, very, very, very, very, very, very, very,
>> > very, long
>> >   - short
>> >
>> > I have tried different settings for org-list-ending-method but this
>> > doesn't change the result.
>> >
>> > Has anybody seen this or know a fix?
>> 
>> Hi Michael,
>> 
>> This wraps okay for me.  I get the following:
>> 
>> - one
>>   - very, very, very, very, very, very, very, very, very, very, very,
>>     very, long
>>   - short
>> 
>> Have you tried it with a minimal emacs setup?  Maybe it's something in
>> your customizations that affects this.
>> 
>
> With fill-paragraph, I get what Bernt gets. With
> mark-paragraph/fill-region, I get what Michael gets. This is with emacs
> -q -l minimal.emacs. In both cases, I start with point at the beginning
> of the very, very long line.
>
> Org-mode version 7.5 (release_7.5.7.g4090.dirty)
> GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2010-11-17 on alphaville

Thanks Nick,

I can also reproduce this.  I was incorrectly using fill-paragraph the
first time.

Regards,
-- 
Bernt

Re: lists and fill-region

[Nicolas]

Hello,

michael hohn <mhhohn@gmail.com> writes:

> after upgrading to the current git head (from a version around 6.36),
> fill-region produces wrong indentation for my lists.  Starting with
>
> - one
>   - very, very, very, very, very, very, very, very, very, very, very, very, long
>   - short
>
> and marking the second item via mark-paragraph followed by fill-region
> results in
>
> - one
>   - very, very, very, very, very, very, very, very, very, very, very,
> very, long
>   - short
>

I have pushed a fix for this case. Thanks for your report, it reminds me
filling in lists is still a bit fragile, and needs some care.

Regards,

-- 
Nicolas

Re: lists and fill-region

[michael hohn]

>
> I have pushed a fix for this case. Thanks for your report, it reminds me
> filling in lists is still a bit fragile, and needs some care.
>
Thanks for the quick response!  The list filling is very nice already.

Cheers,
Michael

Re: Re: lists and fill-region

[Bastien]

michael hohn <mhhohn@gmail.com> writes:

>>
>> I have pushed a fix for this case. Thanks for your report, it reminds me
>> filling in lists is still a bit fragile, and needs some care.
>>
> Thanks for the quick response!  The list filling is very nice already.

Indeed -- and I cannot thank Nicolas enough for all the work he does in
this area.

-- 
 Bastien