From: rey-coyrehourcq <sebastien.rey-coyrehourcq@univ-rouen.fr>
To: Matt Huszagh <huszaghmatt@gmail.com>
Cc: Bastien <bzg@gnu.org>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: babel default header args as functions
Date: Wed, 14 Oct 2020 16:29:46 +0200 [thread overview]
Message-ID: <10a1eb431cef518de142b3518b7e2368015c483c.camel@univ-rouen.fr> (raw)
In-Reply-To: <871ri0c2p8.fsf@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1242 bytes --]
Hi Matt,
I'm unfamilliar with patch by mail but i try to apply your patch to my melpa local org 9.4 version used by doom emacs.
Patch hang on Hunk #3, i attach the .rej file.
patch -p1 < 0001-ob-core.el-Add-ability-to-use-closures-as-default-he.patch
File to patch: ob-core.el
patching file ob-core.el
Hunk #1 succeeded at 467 (offset -6 lines).
Hunk #2 succeeded at 596 (offset -16 lines).
Hunk #3 FAILED at 2745.
Hunk #4 succeeded at 2714 (offset -51 lines).
1 out of 4 hunks FAILED -- saving rejects to file ob-core.el.rej
patch unexpectedly ends in middle of line
Best
Le mercredi 14 octobre 2020 à 07:16 -0700, Matt Huszagh a écrit :
> rey-coyrehourcq <sebastien.rey-coyrehourcq@univ-rouen.fr> writes:
>
> > I'm interested by this functionality, do you know if it was merged or i need to apply patch locally ?
>
> Hi SR,
>
> This hasn't been merged yet. I believe it's ready, but we're just
> waiting on a maintainer to apply it upstream. If you're able to apply
> the patch locally and provide feedback that always helps.
>
> Matt
--
Sébastien Rey-Coyrehourcq
Research Engineer UMR IDEES
02.35.14.69.30
{Stronger security for your email, follow EFF tutorial : https://ssd.eff.org/}
[-- Attachment #1.2: ob-core.el.rej --]
[-- Type: text/x-reject, Size: 848 bytes --]
--- lisp/ob-core.el
+++ lisp/ob-core.el
@@ -2745,12 +2786,21 @@ parameters when merging lists."
results-exclusive-groups
results
(split-string
- (if (stringp value) value (eval value t))))))
+ (if (stringp value)
+ value
+ (if (functionp value)
+ (funcall value)
+ (eval value t)))))))
(`(:exports . ,value)
(setq exports (funcall merge
exports-exclusive-groups
exports
- (split-string (or value "")))))
+ (split-string (or
+ (if value
+ (if (functionp value)
+ (funcall value)
+ value)
+ ""))))))
;; Regular keywords: any value overwrites the previous one.
(_ (setq params (cons pair (assq-delete-all (car pair) params)))))))
;; Handle `:var' and clear out colnames and rownames for replaced
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-14 14:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 7:50 babel default header args as functions Matt Huszagh
2020-08-28 18:17 ` Matt Huszagh
2020-09-02 16:09 ` Matt Huszagh
2020-09-05 15:47 ` Bastien
2020-09-05 18:53 ` Tom Gillespie
2020-09-05 19:11 ` Huszaghmatt
2020-09-06 5:00 ` Bastien
2020-09-06 9:25 ` Tom Gillespie
2020-09-09 19:06 ` Matt Huszagh
2020-09-09 19:33 ` Tom Gillespie
2020-10-14 10:31 ` rey-coyrehourcq
2020-10-14 14:16 ` Matt Huszagh
2020-10-14 14:29 ` rey-coyrehourcq [this message]
2020-10-15 3:38 ` Matt Huszagh
2020-09-06 2:10 ` stardiviner
2020-09-09 19:20 ` Matt Huszagh
2020-12-22 7:08 ` Matt Huszagh
2021-09-26 8:14 ` Bastien
2021-09-29 0:37 ` Matt Huszagh
2021-09-29 1:30 ` Matt Huszagh
2021-09-29 1:45 ` Matt Huszagh
2021-09-29 4:04 ` Timothy
2021-09-29 4:53 ` Matt Huszagh
2021-09-29 7:28 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10a1eb431cef518de142b3518b7e2368015c483c.camel@univ-rouen.fr \
--to=sebastien.rey-coyrehourcq@univ-rouen.fr \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=huszaghmatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).