From: rey-coyrehourcq <sebastien.rey-coyrehourcq@univ-rouen.fr>
To: Tom Gillespie <tgbugs@gmail.com>, Matt Huszagh <huszaghmatt@gmail.com>
Cc: Bastien <bzg@gnu.org>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: babel default header args as functions
Date: Wed, 14 Oct 2020 12:31:04 +0200 [thread overview]
Message-ID: <f2582fb1a922520690fdd4434d9fda762c2cb4fc.camel@univ-rouen.fr> (raw)
In-Reply-To: <CA+G3_POLDa9fgir6O+nv-OJE4ECGmganmNvKbv=rrz94fPbr6g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]
Hi there,
I'm interested by this functionality, do you know if it was merged or i need to apply patch locally ?
Thanks Matt for your work,
Best
SR
Le mercredi 09 septembre 2020 à 12:33 -0700, Tom Gillespie a écrit :
> Hi Matt,
> Looking good here. Thanks!
> Tom
>
> On Wed, Sep 9, 2020 at 12:06 PM Matt Huszagh <huszaghmatt@gmail.com> wrote:
> > Tom Gillespie <tgbugs@gmail.com> writes:
> >
> > > [...] I have a number of use
> > > cases that I can imagine would benefit greatly from being able to
> > > define a :header-args: :header (lambda () "yay!") property as a
> > > closure (and actually I assumed that it would just work that way if I
> > > tried to do it, clearly not though). I can't tell for sure if the
> > > patch enables this behavior though or whether I would still get a
> > > Wrong type argument error.
> >
> > This should work. Do you have reason for believing it might not?
>
> With the patch applied this is working on my end.
>
> * test header
> :PROPERTIES:
> :header-args:bash: :tangle (lambda () "./from-header.sh")
> :END:
>
> #+begin_src bash :shebang "#!/usr/bin/env bash"
> echo yes
> #+end_src
>
> > > [...] Looking
> > > at the patch it seems that it preserves the behavior of performing the
> > > evaluation of the closures at the source block, but I'm not 100% sure.
> >
> > I'm not sure I completely understand what you mean here. However, the
> > closures are evaluated when point is at the source block, during the
> > source block evaluation, not when the default headers are declared. This
> > allows the closures to use context-dependent functionality (e.g. you can
> > call `org-element-at-point' inside the closure and retrieve whatever
> > information you want). Does this address your concern? Please clarify if
> > I've missed your point.
>
> Yep, you've got it.
>
> > > If the default header closures are being evaluated before checking
> > > whether they have been superseded by the headers on a block then that
> > > is incorrect and they should not be evaluated until it is clear that
> > > they are the value of the header for that block and have not been
> > > superseded.
> >
> > I've fixed my patch (attached) so that now closures are only evaluated
> > when they are used as part of the final set of headers.
>
> Great.
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-14 10:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 7:50 babel default header args as functions Matt Huszagh
2020-08-28 18:17 ` Matt Huszagh
2020-09-02 16:09 ` Matt Huszagh
2020-09-05 15:47 ` Bastien
2020-09-05 18:53 ` Tom Gillespie
2020-09-05 19:11 ` Huszaghmatt
2020-09-06 5:00 ` Bastien
2020-09-06 9:25 ` Tom Gillespie
2020-09-09 19:06 ` Matt Huszagh
2020-09-09 19:33 ` Tom Gillespie
2020-10-14 10:31 ` rey-coyrehourcq [this message]
2020-10-14 14:16 ` Matt Huszagh
2020-10-14 14:29 ` rey-coyrehourcq
2020-10-15 3:38 ` Matt Huszagh
2020-09-06 2:10 ` stardiviner
2020-09-09 19:20 ` Matt Huszagh
2020-12-22 7:08 ` Matt Huszagh
2021-09-26 8:14 ` Bastien
2021-09-29 0:37 ` Matt Huszagh
2021-09-29 1:30 ` Matt Huszagh
2021-09-29 1:45 ` Matt Huszagh
2021-09-29 4:04 ` Timothy
2021-09-29 4:53 ` Matt Huszagh
2021-09-29 7:28 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2582fb1a922520690fdd4434d9fda762c2cb4fc.camel@univ-rouen.fr \
--to=sebastien.rey-coyrehourcq@univ-rouen.fr \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=huszaghmatt@gmail.com \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).