emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* end-of-defun odd behaviour in org mode
@ 2014-04-21  0:28 Leo Liu
  2014-04-21 17:26 ` Bastien
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Liu @ 2014-04-21  0:28 UTC (permalink / raw)
  To: emacs-orgmode

Hi there,

While adding support for org-mode in easy-kill¹ I have discovered C-M-a
and C-M-e work asymmetrically. C-M-e moves forward 2 headlines while
C-M-a move back 1.

Cheers,
Leo

Footnotes: 
¹  https://github.com/leoliu/easy-kill

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: end-of-defun odd behaviour in org mode
  2014-04-21  0:28 end-of-defun odd behaviour in org mode Leo Liu
@ 2014-04-21 17:26 ` Bastien
  2014-04-22  1:58   ` Leo Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2014-04-21 17:26 UTC (permalink / raw)
  To: Leo Liu; +Cc: emacs-orgmode

Hi Leo,

Leo Liu <sdl.web@gmail.com> writes:

> While adding support for org-mode in easy-kill¹ I have discovered C-M-a
> and C-M-e work asymmetrically. C-M-e moves forward 2 headlines while
> C-M-a move back 1.

Commit 76fa97922 changed C-M-a and C-M-e to `org-backward-element'
and `org-forward-element' but I know see it was wrong, so I partially
reverted it, the old behavior makes more sense.

Thanks for reporting this,

http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=76fa97922

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: end-of-defun odd behaviour in org mode
  2014-04-21 17:26 ` Bastien
@ 2014-04-22  1:58   ` Leo Liu
  2014-04-22  8:51     ` Bastien
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Liu @ 2014-04-22  1:58 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

On 2014-04-21 19:26 +0200, Bastien wrote:
> Commit 76fa97922 changed C-M-a and C-M-e to `org-backward-element'
> and `org-forward-element' but I know see it was wrong, so I partially
> reverted it, the old behavior makes more sense.

Thanks.

> Thanks for reporting this,
>
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=76fa97922

Seems there is another bug after this change:

   C-M-e moves forward 1 and C-M-a moves back 0.

org-back-to-heading does not fully satisfy the protocol of
beginning-of-defun-function.

Leo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: end-of-defun odd behaviour in org mode
  2014-04-22  1:58   ` Leo Liu
@ 2014-04-22  8:51     ` Bastien
  2014-04-22 11:57       ` Leo Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2014-04-22  8:51 UTC (permalink / raw)
  To: Leo Liu; +Cc: emacs-orgmode

Hi Leo,

Leo Liu <sdl.web@gmail.com> writes:

> Seems there is another bug after this change:
>
>    C-M-e moves forward 1 and C-M-a moves back 0.
>
> org-back-to-heading does not fully satisfy the protocol of
> beginning-of-defun-function.

Yeah -- I pushed a fix, relying back again on `org-forward-element'
and `org-backward-element'.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: end-of-defun odd behaviour in org mode
  2014-04-22  8:51     ` Bastien
@ 2014-04-22 11:57       ` Leo Liu
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Liu @ 2014-04-22 11:57 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

On 2014-04-22 10:51 +0200, Bastien wrote:
> Yeah -- I pushed a fix, relying back again on `org-forward-element'
> and `org-backward-element'.

Thanks. seems to work fine now.

Leo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-04-22 11:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-21  0:28 end-of-defun odd behaviour in org mode Leo Liu
2014-04-21 17:26 ` Bastien
2014-04-22  1:58   ` Leo Liu
2014-04-22  8:51     ` Bastien
2014-04-22 11:57       ` Leo Liu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).