emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Footnotes bug
@ 2009-03-28  3:34 Matthew Lundin
  2009-03-30  9:26 ` Carsten Dominik
  0 siblings, 1 reply; 3+ messages in thread
From: Matthew Lundin @ 2009-03-28  3:34 UTC (permalink / raw)
  To: Org Mode List

Hi Carsten,

I would like to report a bug in org-footnote. I have set
org-footnote-define-inline to t. I also have the following settings:

--8<---------------cut here---------------start------------->8---
(setq org-footnote-section nil)
(setq org-footnote-auto-label nil)
--8<---------------cut here---------------end--------------->8---

When I call org-footnote-action, footnotes are entered inline, as
expected. But when I call org-footnote-action with an argument and then
select "sort," footnote definitions are created at the bottom of the
section (as expected), but the inline footnote definition is not
removed, leading to duplicate definitions. If I sort again, a duplicate
set of definitions is created at the bottom of the file.

The following progession should help to illustrate what I mean. 

1. Inline footnotes

,----
| #+startup: fninline
| 
| * Test
| 
| Footnote one.[fn:one: This is a footnote.] Footnote two.[fn:two: This
| is another footnote.]
`----

2. After the first sort

,----
| #+startup: fninline
| 
| * Test
| 
| Footnote one.[fn:one: This is a footnote.] Footnote two.[fn:two: This
| is another footnote.]
| 
| [fn:one] This is a footnote.
| 
| [fn:two] This
| is another footnote.
`----

3. After a second sort.

,----
| #+startup: fninline
| 
| * Test
| 
| Footnote one.[fn:one: This is a footnote.] Footnote two.[fn:two: This
| is another footnote.]
| 
| [fn:one] This is a footnote.
| 
| [fn:two] This
| is another footnote.
| 
| [fn:one] This is a footnote.
| 
| [fn:two] This
| is another footnote.
`----

Thanks,
Matt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Footnotes bug
  2009-03-28  3:34 Footnotes bug Matthew Lundin
@ 2009-03-30  9:26 ` Carsten Dominik
  2009-03-30 11:43   ` Matthew Lundin
  0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2009-03-30  9:26 UTC (permalink / raw)
  To: Matthew Lundin; +Cc: Org Mode List

Hi Matt,

On Mar 28, 2009, at 4:34 AM, Matthew Lundin wrote:

> Hi Carsten,
>
> I would like to report a bug in org-footnote. I have set
> org-footnote-define-inline to t. I also have the following settings:
>
> --8<---------------cut here---------------start------------->8---
> (setq org-footnote-section nil)
> (setq org-footnote-auto-label nil)
> --8<---------------cut here---------------end--------------->8---
>
> When I call org-footnote-action, footnotes are entered inline, as
> expected. But when I call org-footnote-action with an argument and  
> then
> select "sort," footnote definitions are created at the bottom of the
> section (as expected),


I believe this expectation is wrong for inline footnotes which
should be left alone when only sorting footnotes.  That was a
bug which I fixed now.  Let me know if I am missing something here.

- Carsten

> but the inline footnote definition is not
> removed, leading to duplicate definitions. If I sort again, a  
> duplicate
> set of definitions is created at the bottom of the file.
>
> The following progession should help to illustrate what I mean.
>
> 1. Inline footnotes
>
> ,----
> | #+startup: fninline
> |
> | * Test
> |
> | Footnote one.[fn:one: This is a footnote.] Footnote two.[fn:two:  
> This
> | is another footnote.]
> `----
>
> 2. After the first sort
>
> ,----
> | #+startup: fninline
> |
> | * Test
> |
> | Footnote one.[fn:one: This is a footnote.] Footnote two.[fn:two:  
> This
> | is another footnote.]
> |
> | [fn:one] This is a footnote.
> |
> | [fn:two] This
> | is another footnote.
> `----
>
> 3. After a second sort.
>
> ,----
> | #+startup: fninline
> |
> | * Test
> |
> | Footnote one.[fn:one: This is a footnote.] Footnote two.[fn:two:  
> This
> | is another footnote.]
> |
> | [fn:one] This is a footnote.
> |
> | [fn:two] This
> | is another footnote.
> |
> | [fn:one] This is a footnote.
> |
> | [fn:two] This
> | is another footnote.
> `----
>
> Thanks,
> Matt
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Footnotes bug
  2009-03-30  9:26 ` Carsten Dominik
@ 2009-03-30 11:43   ` Matthew Lundin
  0 siblings, 0 replies; 3+ messages in thread
From: Matthew Lundin @ 2009-03-30 11:43 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: Org Mode List

Hi Carsten,

Carsten Dominik <carsten.dominik@gmail.com> writes:

>> When I call org-footnote-action, footnotes are entered inline, as
>> expected. But when I call org-footnote-action with an argument and
>> then
>> select "sort," footnote definitions are created at the bottom of the
>> section (as expected),
>
>
> I believe this expectation is wrong for inline footnotes which
> should be left alone when only sorting footnotes.  That was a
> bug which I fixed now.  Let me know if I am missing something here.


Thanks so much for fixing this. Yes, I see that it is much better *not*
to have inline footnotes sorted, since they are, after all, inline. The
great thing is that one can always convert them by using normalize.

By the way, I can't tell you how much I appreciate the elegance of your
solution to footnotes in org-mode. As a historian who uses footnotes all
the time, I've found org-mode's footnote features to be the most
convenient and flexible I've ever used.

Best,
Matt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-03-30 11:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-28  3:34 Footnotes bug Matthew Lundin
2009-03-30  9:26 ` Carsten Dominik
2009-03-30 11:43   ` Matthew Lundin

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).