emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)]
@ 2011-09-28 23:43 Dave Abrahams
  2011-09-29  0:33 ` Nick Dokos
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Abrahams @ 2011-09-28 23:43 UTC (permalink / raw)
  To: emacs-orgmode



Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

The documentation doesn't specify whether the cons cells are ANDed or
ORed together when selecting refile targets.

Emacs  : GNU Emacs 23.3.1 (x86_64-apple-darwin10.8.0, Carbon Version 1.6.0 AppKit 1038.36)
 of 2011-09-12 on pluto.luannocracy.com
Package: Org-mode version 7.7 (release_7.7.351.gb8b5)
-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)]
  2011-09-28 23:43 Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)] Dave Abrahams
@ 2011-09-29  0:33 ` Nick Dokos
  2011-09-29  2:09   ` Dave Abrahams
  0 siblings, 1 reply; 6+ messages in thread
From: Nick Dokos @ 2011-09-29  0:33 UTC (permalink / raw)
  To: Dave Abrahams; +Cc: nicholas.dokos, emacs-orgmode

Dave Abrahams <dave@boostpro.com> wrote:

> 
> 
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
> 
>      http://orgmode.org/manual/Feedback.html#Feedback
> 
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
> 
> The documentation doesn't specify whether the cons cells are ANDed or
> ORed together when selecting refile targets.
> 

I'm not really sure what you mean, so let me tell you how I understand
this variable and then come back to the question of what you would like
to see.

AFAIK, the variable is used to construct a set of possible targets: you
select the items to refile and then you select *one* item from this
set. There is completion: as you type, the set is cut down to whatever
subset matches your current input - org does not let you finish until
the refiling target has been specified uniquely.

Each element of the org-refile-targets list generates a set of posssible
targets. The whole set is the union of these partial sets. Since ORs map
to unions and ANDs to intersections, I guess one could say that they are
ORed together, but personally I find it confusing to think of it in
these terms.

Assuming that this is correct, does it help? And if it is correct and it
does help, what would you change in the docs to incorporate this
information? And how? 

Nick

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)]
  2011-09-29  0:33 ` Nick Dokos
@ 2011-09-29  2:09   ` Dave Abrahams
  2011-09-29  3:59     ` Nick Dokos
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Abrahams @ 2011-09-29  2:09 UTC (permalink / raw)
  To: nicholas.dokos; +Cc: emacs-orgmode


on Wed Sep 28 2011, Nick Dokos <nicholas.dokos-AT-hp.com> wrote:

> Dave Abrahams <dave@boostpro.com> wrote:
>
>> 
>> 
>> Remember to cover the basics, that is, what you expected to happen and
>> what in fact did happen.  You don't know how to make a good report?  See
>> 
>>      http://orgmode.org/manual/Feedback.html#Feedback
>> 
>> Your bug report will be posted to the Org-mode mailing list.
>> ------------------------------------------------------------------------
>> 
>> The documentation doesn't specify whether the cons cells are ANDed or
>> ORed together when selecting refile targets.
>> 
>
> I'm not really sure what you mean, so let me tell you how I understand
> this variable and then come back to the question of what you would like
> to see.
>
> AFAIK, the variable is used to construct a set of possible targets: you
> select the items to refile and then you select *one* item from this
> set. There is completion: as you type, the set is cut down to whatever
> subset matches your current input - org does not let you finish until
> the refiling target has been specified uniquely.
>
> Each element of the org-refile-targets list generates a set of posssible
> targets. The whole set is the union of these partial sets. Since ORs map
> to unions and ANDs to intersections, I guess one could say that they are
> ORed together, but personally I find it confusing to think of it in
> these terms.

Then think of it / describe it in terms of set unions.  ORing predicates
creates a set union.

> Assuming that this is correct, does it help? 

Yes.

> And if it is correct and it does help, what would you change in the
> docs to incorporate this information? And how?

I would change the doc for org-refile-targets to say that the resulting
list of targets is the union of all the targets matched by each cons
cell.  I think you could take that pretty much verbatim.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)]
  2011-09-29  2:09   ` Dave Abrahams
@ 2011-09-29  3:59     ` Nick Dokos
  2011-09-29 11:36       ` Dave Abrahams
  2011-10-06  8:13       ` [Accepted] " Carsten Dominik
  0 siblings, 2 replies; 6+ messages in thread
From: Nick Dokos @ 2011-09-29  3:59 UTC (permalink / raw)
  To: Dave Abrahams; +Cc: nicholas.dokos, emacs-orgmode

Dave Abrahams <dave@boostpro.com> wrote:

> I would change the doc for org-refile-targets to say that the resulting
> list of targets is the union of all the targets matched by each cons
> cell.  I think you could take that pretty much verbatim.
> 

How's this?

Nick

---------------------------------------------------------------------------
From f853b04fb474493b3b7b8857794c9f120c5f7822 Mon Sep 17 00:00:00 2001
From: Nick Dokos <nick@dokosmarshall.org>
Date: Wed, 28 Sep 2011 23:49:13 -0400
Subject: [PATCH] Amplify the doc for org-refile-targets

* lisp/org.el: (org-refile-targets) Elaborated the documentation of
               the variable as suggested by Dave Abrahams.

TINYCHANGE
---
 lisp/org.el |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 945d759..68c6912 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -1864,7 +1864,7 @@ (defcustom org-log-refile nil
 
 (defcustom org-refile-targets nil
   "Targets for refiling entries with \\[org-refile].
-This is list of cons cells.  Each cell contains:
+This is a list of cons cells.  Each cell contains:
 - a specification of the files to be considered, either a list of files,
   or a symbol whose function or variable value will be used to retrieve
   a file name or a list of file names.  If you use `org-agenda-files' for
@@ -1886,6 +1886,10 @@ (defcustom org-refile-targets nil
     Note that, when `org-odd-levels-only' is set, level corresponds to
     order in hierarchy, not to the number of stars.
 
+Each element of this list generates a set of possible targets.
+The union of these sets is presented (with completion) to
+the user by `org-refile'.
+
 You can set the variable `org-refile-target-verify-function' to a function
 to verify each headline found by the simple criteria above.
 
-- 
1.7.5.1.169.g505a1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)]
  2011-09-29  3:59     ` Nick Dokos
@ 2011-09-29 11:36       ` Dave Abrahams
  2011-10-06  8:13       ` [Accepted] " Carsten Dominik
  1 sibling, 0 replies; 6+ messages in thread
From: Dave Abrahams @ 2011-09-29 11:36 UTC (permalink / raw)
  To: nicholas.dokos; +Cc: emacs-orgmode


Beautiful

on Wed Sep 28 2011, Nick Dokos <nicholas.dokos-AT-hp.com> wrote:

> Dave Abrahams <dave@boostpro.com> wrote:
>
>> I would change the doc for org-refile-targets to say that the resulting
>> list of targets is the union of all the targets matched by each cons
>> cell.  I think you could take that pretty much verbatim.
>> 
>
> How's this?
>
> Nick
>
> ---------------------------------------------------------------------------
> From f853b04fb474493b3b7b8857794c9f120c5f7822 Mon Sep 17 00:00:00 2001
> From: Nick Dokos <nick@dokosmarshall.org>
> Date: Wed, 28 Sep 2011 23:49:13 -0400
> Subject: [PATCH] Amplify the doc for org-refile-targets
>
> * lisp/org.el: (org-refile-targets) Elaborated the documentation of
>                the variable as suggested by Dave Abrahams.
>
> TINYCHANGE
> ---
>  lisp/org.el |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 945d759..68c6912 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -1864,7 +1864,7 @@ (defcustom org-log-refile nil
>
>  (defcustom org-refile-targets nil
>    "Targets for refiling entries with \\[org-refile].
> -This is list of cons cells.  Each cell contains:
> +This is a list of cons cells.  Each cell contains:
>  - a specification of the files to be considered, either a list of files,
>    or a symbol whose function or variable value will be used to retrieve
>    a file name or a list of file names.  If you use `org-agenda-files' for
> @@ -1886,6 +1886,10 @@ (defcustom org-refile-targets nil
>      Note that, when `org-odd-levels-only' is set, level corresponds to
>      order in hierarchy, not to the number of stars.
>
> +Each element of this list generates a set of possible targets.
> +The union of these sets is presented (with completion) to
> +the user by `org-refile'.
> +
>  You can set the variable `org-refile-target-verify-function' to a function
>  to verify each headline found by the simple criteria above.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Accepted] Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)]
  2011-09-29  3:59     ` Nick Dokos
  2011-09-29 11:36       ` Dave Abrahams
@ 2011-10-06  8:13       ` Carsten Dominik
  1 sibling, 0 replies; 6+ messages in thread
From: Carsten Dominik @ 2011-10-06  8:13 UTC (permalink / raw)
  To: emacs-orgmode

Patch 965 (http://patchwork.newartisans.com/patch/965/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C3103.1317268754%40alphaville.dokosmarshall.org%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] Bug: org-refile-targets doesn't say whether it's AND or OR [7.7
> 	(release_7.7.351.gb8b5)]
> Date: Thu, 29 Sep 2011 08:59:14 -0000
> From: Nick Dokos <nicholas.dokos@hp.com>
> X-Patchwork-Id: 965
> Message-Id: <3103.1317268754@alphaville.dokosmarshall.org>
> To: Dave Abrahams <dave@boostpro.com>
> Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
> 
> Dave Abrahams <dave@boostpro.com> wrote:
> 
> > I would change the doc for org-refile-targets to say that the resulting
> > list of targets is the union of all the targets matched by each cons
> > cell.  I think you could take that pretty much verbatim.
> > 
> 
> How's this?
> 
> Nick
> 
> ---------------------------------------------------------------------------
> >From f853b04fb474493b3b7b8857794c9f120c5f7822 Mon Sep 17 00:00:00 2001
> From: Nick Dokos <nick@dokosmarshall.org>
> Date: Wed, 28 Sep 2011 23:49:13 -0400
> Subject: [PATCH] Amplify the doc for org-refile-targets
> 
> * lisp/org.el: (org-refile-targets) Elaborated the documentation of
>                the variable as suggested by Dave Abrahams.
> 
> TINYCHANGE
> 
> ---
> lisp/org.el |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index 945d759..68c6912 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -1864,7 +1864,7 @@ (defcustom org-log-refile nil
>  
>  (defcustom org-refile-targets nil
>    "Targets for refiling entries with \\[org-refile].
> -This is list of cons cells.  Each cell contains:
> +This is a list of cons cells.  Each cell contains:
>  - a specification of the files to be considered, either a list of files,
>    or a symbol whose function or variable value will be used to retrieve
>    a file name or a list of file names.  If you use `org-agenda-files' for
> @@ -1886,6 +1886,10 @@ (defcustom org-refile-targets nil
>      Note that, when `org-odd-levels-only' is set, level corresponds to
>      order in hierarchy, not to the number of stars.
>  
> +Each element of this list generates a set of possible targets.
> +The union of these sets is presented (with completion) to
> +the user by `org-refile'.
> +
>  You can set the variable `org-refile-target-verify-function' to a function
>  to verify each headline found by the simple criteria above.
>  
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-06  8:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-28 23:43 Bug: org-refile-targets doesn't say whether it's AND or OR [7.7 (release_7.7.351.gb8b5)] Dave Abrahams
2011-09-29  0:33 ` Nick Dokos
2011-09-29  2:09   ` Dave Abrahams
2011-09-29  3:59     ` Nick Dokos
2011-09-29 11:36       ` Dave Abrahams
2011-10-06  8:13       ` [Accepted] " Carsten Dominik

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).