emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: tsd@tsdye.com (Thomas S. Dye)
To: "Steven Rémot" <steven.remot@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el
Date: Fri, 08 Aug 2014 14:38:26 -1000	[thread overview]
Message-ID: <m2d2cacxa5.fsf@tsdye.com> (raw)
In-Reply-To: <53E52F05.3040106@gmail.com> ("Steven \=\?utf-8\?Q\?R\=C3\=A9mot\=22\?\= \=\?utf-8\?Q\?'s\?\= message of "Fri, 08 Aug 2014 22:11:49 +0200")

Aloha Steven,

Steven Rémot <steven.remot@gmail.com> writes:

> Hi,
>
> I did some changes to support :dbname, :dbhost and :database in SQL
> code blocks when using postgresql engine.
>
> Even if it was possible to specify this information using :cmdline
> parameter, I thought it was a bit cleaner to be able to provide this
> information in a way independent from the command line.
>
> I will gladly accept any remark / comment on this patch.
>
> Regards,
> Steven Rémot

I'm not certain who is maintaining ob-sql.el, so I'm not replying in any
directly useful way.  However, this patch looks straightforward and
good to me.

Have you signed FSF papers?  If so, the maintainer can accept (or
reject) your patch.  If not, then you'll need to identify it as a tiny
change (see http://orgmode.org/worg/org-contribute.html).

Thanks for this contribution to Org mode.

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com

next prev parent reply	other threads:[~2014-08-09  0:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 20:11 [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el Steven Rémot
2014-08-09  0:38 ` Thomas S. Dye [this message]
2014-08-09 10:04   ` Steven Rémot
2014-08-09 15:31     ` Thomas S. Dye
2014-08-09 16:02       ` Steven Rémot
2014-09-20 11:55       ` Steven Rémot
2014-09-20 12:16         ` Nicolas Goaziou
2014-09-20 13:31           ` Steven Rémot
2014-09-20 21:09             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d2cacxa5.fsf@tsdye.com \
    --to=tsd@tsdye.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=steven.remot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).