From mboxrd@z Thu Jan  1 00:00:00 1970
From: tsd@tsdye.com (Thomas S. Dye)
Subject: Re: [PATCH] Add support for :dbhost, :dbuser and :database
 parameters for poastgresql in ob-sql.el
Date: Fri, 08 Aug 2014 14:38:26 -1000
Message-ID: <m2d2cacxa5.fsf@tsdye.com>
References: <53E52F05.3040106@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tsd@tsdye.com>) id 1XFugH-0003XA-QS
	for emacs-orgmode@gnu.org; Fri, 08 Aug 2014 20:38:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tsd@tsdye.com>) id 1XFugB-0007Ry-JB
	for emacs-orgmode@gnu.org; Fri, 08 Aug 2014 20:38:45 -0400
Received: from gproxy3-pub.mail.unifiedlayer.com ([69.89.30.42]:49331)
	by eggs.gnu.org with smtp (Exim 4.71) (envelope-from <tsd@tsdye.com>)
	id 1XFugB-0007Rq-CC
	for emacs-orgmode@gnu.org; Fri, 08 Aug 2014 20:38:39 -0400
In-Reply-To: <53E52F05.3040106@gmail.com> ("Steven
	\=\?utf-8\?Q\?R\=C3\=A9mot\=22\?\=
	\=\?utf-8\?Q\?'s\?\= message of "Fri, 08 Aug 2014 22:11:49 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Steven =?utf-8?Q?R=C3=A9mot?= <steven.remot@gmail.com>
Cc: emacs-orgmode@gnu.org

Aloha Steven,

Steven R=C3=A9mot <steven.remot@gmail.com> writes:

> Hi,
>
> I did some changes to support :dbname, :dbhost and :database in SQL
> code blocks when using postgresql engine.
>
> Even if it was possible to specify this information using :cmdline
> parameter, I thought it was a bit cleaner to be able to provide this
> information in a way independent from the command line.
>
> I will gladly accept any remark / comment on this patch.
>
> Regards,
> Steven R=C3=A9mot

I'm not certain who is maintaining ob-sql.el, so I'm not replying in any
directly useful way.  However, this patch looks straightforward and
good to me.

Have you signed FSF papers?  If so, the maintainer can accept (or
reject) your patch.  If not, then you'll need to identify it as a tiny
change (see http://orgmode.org/worg/org-contribute.html).

Thanks for this contribution to Org mode.

All the best,
Tom

--=20
Thomas S. Dye
http://www.tsdye.com