emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ken Mankoff <mankoff@gmail.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Custom agenda shows all TODO
Date: Sat, 07 Mar 2015 18:20:35 -0500	[thread overview]
Message-ID: <m2bnk4s8cc.fsf@gmail.com> (raw)
In-Reply-To: <m2ioedrrg0.fsf@gmail.com>

On 2015-03-07 at 06:13, Ken Mankoff <mankoff@gmail.com> wrote:
> Has something in the Agenda changed recently? I'm using Org from git
> and since upgrading my refresh Agenda behaves differently. I've
> searched the mailing list but found no mention of this. I know there
> were some 8.2 to 8.3 changes. Is this one of them?
>
> I have this in my custom agenda:
>
>     (todo "INPROGRESS" ((org-agenda-overriding-header "In Progress")))
>
> And when I load that Agenda, I see only TODO items with status
> "INPROGRESS".
>
> If I press "r" in a different section, I still see what I expect.
>
> But oddly if I press "r" in the "In Progress" section, then it
> refreshes and shows me *all* TODO items, not just INPROGRESS TODO
> items.

I've traced this issues (bug?) to a change between ba544e4 and d92ef95. I'm not sure what change, but the issue is in the agenda, and the diff for org-agenda.el is:


@@ -4789,7 +4789,7 @@ for a keyword.  A numeric prefix directly selects the Nth keyword in
       (or org-agenda-multi (org-agenda-fit-window-to-buffer))
       (add-text-properties (point-min) (point-max)
                           `(org-agenda-type todo
-                                            org-last-args ,arg
+                                            org-last-args (,arg)
                                             org-redo-cmd ,org-agenda-redo-command
                                             org-series-cmd ,org-cmd))
       (org-agenda-finalize)



I have tested it with this MWE, used between those two git versions (checkout, make autoloads, and C-c C-x ! in a clean Emacs org buffer loaded with only this):


(add-to-list 'load-path "~/local/src/org-mode/lisp")
(add-to-list 'load-path "~/local/src/org-mode/contrib" t)
(require 'org)
(setq org-directory "~/Documents/Org")
(setq org-agenda-files (quote ("~/Documents/Org/"))
(define-key global-map "\C-ca" 'org-agenda)
(setq org-agenda-custom-commands
      '(
        ("c" "My Custom Agenda"
         (
          (todo "INPROGRESS")
          ))))


And then "r" after loading the custom agenda shows *all* TODO items, not just INPROGRESS TODO items.

  -k.

next prev parent reply	other threads:[~2015-03-07 23:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 11:13 Custom agenda shows all TODO Ken Mankoff
2015-03-07 23:20 ` Ken Mankoff [this message]
2015-03-08  0:21   ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bnk4s8cc.fsf@gmail.com \
    --to=mankoff@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).