From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ken Mankoff Subject: Re: Custom agenda shows all TODO Date: Sat, 07 Mar 2015 18:20:35 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUO1Q-00064N-KP for emacs-orgmode@gnu.org; Sat, 07 Mar 2015 18:20:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUO1N-0002um-Ep for emacs-orgmode@gnu.org; Sat, 07 Mar 2015 18:20:40 -0500 Received: from mail-qc0-x22d.google.com ([2607:f8b0:400d:c01::22d]:45470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUO1N-0002ug-9m for emacs-orgmode@gnu.org; Sat, 07 Mar 2015 18:20:37 -0500 Received: by qcwb13 with SMTP id b13so21332965qcw.12 for ; Sat, 07 Mar 2015 15:20:37 -0800 (PST) Received: from gorgonzola ([71.58.77.153]) by mx.google.com with ESMTPSA id g69sm7104289qkh.18.2015.03.07.15.20.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Mar 2015 15:20:36 -0800 (PST) In-reply-to: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode On 2015-03-07 at 06:13, Ken Mankoff wrote: > Has something in the Agenda changed recently? I'm using Org from git > and since upgrading my refresh Agenda behaves differently. I've > searched the mailing list but found no mention of this. I know there > were some 8.2 to 8.3 changes. Is this one of them? > > I have this in my custom agenda: > > (todo "INPROGRESS" ((org-agenda-overriding-header "In Progress"))) > > And when I load that Agenda, I see only TODO items with status > "INPROGRESS". > > If I press "r" in a different section, I still see what I expect. > > But oddly if I press "r" in the "In Progress" section, then it > refreshes and shows me *all* TODO items, not just INPROGRESS TODO > items. I've traced this issues (bug?) to a change between ba544e4 and d92ef95. I'm not sure what change, but the issue is in the agenda, and the diff for org-agenda.el is: @@ -4789,7 +4789,7 @@ for a keyword. A numeric prefix directly selects the Nth keyword in (or org-agenda-multi (org-agenda-fit-window-to-buffer)) (add-text-properties (point-min) (point-max) `(org-agenda-type todo - org-last-args ,arg + org-last-args (,arg) org-redo-cmd ,org-agenda-redo-command org-series-cmd ,org-cmd)) (org-agenda-finalize) I have tested it with this MWE, used between those two git versions (checkout, make autoloads, and C-c C-x ! in a clean Emacs org buffer loaded with only this): (add-to-list 'load-path "~/local/src/org-mode/lisp") (add-to-list 'load-path "~/local/src/org-mode/contrib" t) (require 'org) (setq org-directory "~/Documents/Org") (setq org-agenda-files (quote ("~/Documents/Org/")) (define-key global-map "\C-ca" 'org-agenda) (setq org-agenda-custom-commands '( ("c" "My Custom Agenda" ( (todo "INPROGRESS") )))) And then "r" after loading the custom agenda shows *all* TODO items, not just INPROGRESS TODO items. -k.