From: Dave Abrahams <dave@boostpro.com>
To: emacs-orgmode@gnu.org
Subject: Bug: org-store-link only works interactively [7.4]
Date: Sun, 19 Dec 2010 23:51:59 -0900 [thread overview]
Message-ID: <m2aak0kes0.wl%dave@boostpro.com> (raw)
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
Because of this stanza at the end of org-store-link:
(if (and (or (interactive-p) executing-kbd-macro) link)
(progn
(setq org-stored-links
(cons (list link desc) org-stored-links))
(message "Stored: %s" (or desc link))
(when custom-id
(setq link (concat "file:" (abbreviate-file-name (buffer-file-name))
"::#" custom-id))
(setq org-stored-links
(cons (list link desc) org-stored-links))))
(or agenda-link (and link (org-make-link-string link desc))))))
org-stored-links will only be updated if the function is called
interactively. I'm not sure why you would want to neuter
org-store-link otherwise, but the docs for interactive-p say:
The only known proper use of `interactive-p' is in deciding whether to
display a helpful message, or how to display it. If you're thinking
of using it for any other purpose, it is quite likely that you're
making a mistake.
Granted, it also says:
Think: what do you want to do when the command is called from a
keyboard macro?
and you handle that particular case explicitly. However, there are
other reasons not to write functions this way (namely, someone like me
will want to store a link programmatically, and will then have to
spend a long time debugging to discover why it doesn't work).
Emacs : GNU Emacs 23.2.1 (x86_64-apple-darwin, NS apple-appkit-1038.29)
of 2010-05-08 on black.local
Package: Org-mode version 7.4
--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
next reply other threads:[~2010-12-20 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 8:51 Dave Abrahams [this message]
2011-02-11 9:57 ` Bug: org-store-link only works interactively [7.4] Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2aak0kes0.wl%dave@boostpro.com \
--to=dave@boostpro.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).