From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Abrahams Subject: Bug: org-store-link only works interactively [7.4] Date: Sun, 19 Dec 2010 23:51:59 -0900 Message-ID: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from [140.186.70.92] (port=50902 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUbTd-0002HE-1I for emacs-orgmode@gnu.org; Mon, 20 Dec 2010 03:52:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PUbTb-00041x-Ee for emacs-orgmode@gnu.org; Mon, 20 Dec 2010 03:52:16 -0500 Received: from mail-pv0-f195.google.com ([74.125.83.195]:48528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PUbTb-00041X-9z for emacs-orgmode@gnu.org; Mon, 20 Dec 2010 03:52:15 -0500 Received: by pvb32 with SMTP id 32so331201pvb.6 for ; Mon, 20 Dec 2010 00:52:13 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See http://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org-mode mailing list. ------------------------------------------------------------------------ Because of this stanza at the end of org-store-link: (if (and (or (interactive-p) executing-kbd-macro) link) (progn (setq org-stored-links (cons (list link desc) org-stored-links)) (message "Stored: %s" (or desc link)) (when custom-id (setq link (concat "file:" (abbreviate-file-name (buffer-file-name)) "::#" custom-id)) (setq org-stored-links (cons (list link desc) org-stored-links)))) (or agenda-link (and link (org-make-link-string link desc)))))) org-stored-links will only be updated if the function is called interactively. I'm not sure why you would want to neuter org-store-link otherwise, but the docs for interactive-p say: The only known proper use of `interactive-p' is in deciding whether to display a helpful message, or how to display it. If you're thinking of using it for any other purpose, it is quite likely that you're making a mistake. Granted, it also says: Think: what do you want to do when the command is called from a keyboard macro? and you handle that particular case explicitly. However, there are other reasons not to write functions this way (namely, someone like me will want to store a link programmatically, and will then have to spend a long time debugging to discover why it doesn't work). Emacs : GNU Emacs 23.2.1 (x86_64-apple-darwin, NS apple-appkit-1038.29) of 2010-05-08 on black.local Package: Org-mode version 7.4 -- Dave Abrahams BoostPro Computing http://www.boostpro.com