emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Doro Rose <doroerose@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH]: Fix ob-haskell.el to work with custom ghci prompts
Date: Sat, 18 Nov 2017 12:12:24 +0100	[thread overview]
Message-ID: <m1fu9bg7s7.fsf@gmail.com> (raw)
In-Reply-To: <87y3n4tuvy.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 17 Nov 2017 23:14:57 +0100")

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Doro Rose <doroerose@gmail.com> writes:
>
>> In summary, yes I'm accessing user settings but in a rather
>> noninvasive way. Unfortunately I can't think of a more elegant way to
>> do this.
>
> Let's put it differently then. Isn't it the job of the user, who changed
> their prompt, to configure properly "inf-haskell" library? I don't get
> why it should be a task for "ob-haskell".
>
> This is a genuine question: I don't use Haskell at all.
>
> Regards,

Well the "inf-haskell" library is fine as it is, i.e. the code sent to its buffer
is evaluated correctly in the corresponding buffer.
The problem occurs when sending code  to that buffer via org-babel, since
the interpreter output isn't parsed correctly in `org-babel-comint-with-output`.

As an org-babel user my expectation would be for that to just work out of the
box. -> Without having to figure out that I need to set internal variables defined in
"inf-haskell" or that I need  to add `ansi-color-filter-apply` to
`comint-preoutput-filter-functions`.

  reply	other threads:[~2017-11-18 11:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06  6:53 [PATCH]: Fix ob-haskell.el to work with custom ghci prompts Doro Rose
2017-11-16 21:04 ` Nicolas Goaziou
2017-11-16 22:22   ` Doro Rose
2017-11-17 22:14     ` Nicolas Goaziou
2017-11-18 11:12       ` Doro Rose [this message]
2017-11-29 20:21         ` Nicolas Goaziou
2017-12-02 21:25           ` Doro Rose
2017-12-11 14:14             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1fu9bg7s7.fsf@gmail.com \
    --to=doroerose@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).