From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Doro Rose <doroerose@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH]: Fix ob-haskell.el to work with custom ghci prompts
Date: Thu, 16 Nov 2017 22:04:24 +0100 [thread overview]
Message-ID: <87k1yque93.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m160anx5h5.fsf@gmail.com> (Doro Rose's message of "Mon, 06 Nov 2017 07:53:58 +0100")
Hello,
Doro Rose <doroerose@gmail.com> writes:
> I noticed that ob-haskell.el doesn't support custom ghci prompts at present.
> Custom ghci prompts such as "λ>" are quite popular in the haskell community, see for example
>
> https://stackoverflow.com/questions/42081379/how-to-set-up-org-babel-for-haskell-with-stack
>
> Could you have a look at the following patch and see, wether that would work in general, wrt. coding standars etc.
> Obviously it works on my system, but I'm not an experienced elisp programmer, so I guess there might be room for
> improvement.
Thank you.
> + (require 'inf-haskell)
> + (add-hook 'inferior-haskell-hook
> + (lambda ()
> + (setq-local comint-prompt-regexp
> + (concat haskell-prompt-regexp "\\|^λ?> "))))
Doesn't this kind of configuration ultimately belongs to the user? Org
is not supposed to mess with `haskell-prompt-regexp' in the current
buffer, IMO.
> (let* ((session (cdr (assq :session params)))
> (result-type (cdr (assq :result-type params)))
> (full-body (org-babel-expand-body:generic
> body params
> (org-babel-variable-assignments:haskell params)))
> (session (org-babel-haskell-initiate-session session params))
> + (comint-preoutput-filter-functions
> + (cons 'ansi-color-filter-apply comint-preoutput-filter-functions))
Ditto.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-11-16 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 6:53 [PATCH]: Fix ob-haskell.el to work with custom ghci prompts Doro Rose
2017-11-16 21:04 ` Nicolas Goaziou [this message]
2017-11-16 22:22 ` Doro Rose
2017-11-17 22:14 ` Nicolas Goaziou
2017-11-18 11:12 ` Doro Rose
2017-11-29 20:21 ` Nicolas Goaziou
2017-12-02 21:25 ` Doro Rose
2017-12-11 14:14 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1yque93.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=doroerose@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).