emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

* org-comment-string fontification stopped working in sublevel headlines
@ 2015-08-23 14:54 Martin Carlé
  2015-08-23 19:56 ` Samuel Wales
  2015-08-23 20:50 ` Nicolas Goaziou
  0 siblings, 2 replies; 3+ messages in thread
From: Martin Carlé @ 2015-08-23 14:54 UTC (permalink / raw)
  To: Org-Mode mailing list

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

Hello,

guess the commit c27c101f (08/16/2015 04:14 PM) with the title "org.el: Fix `org-comment-string' fontification" has chosen a bit too harsh 'fixation' method:

Since then, the 'org-special-keyword' face for 'COMMENT' is not applied to heading of lower levels any more but only to the top one.

The minimal example below also demonstrates another possibly unintended fontification.
Bold and italic faces (or the other options of http://orgmode.org/org.html#Emphasis-and-monospace) are extended across lists which they probably should not.

The two issues, however, seem not directly related and I do not know when the second one was introduced.

,---------------------------
| * COMMENT Level 1         
| ** COMMENT Level 2        
| *** TODO COMMENT Level 3  
| 1) load all *.el files    
| 2) tangle all org-* files 
| ***** TODO COMMENT Level 4
| 1) load all /*.el files   
| 2) tangle all org-*/ files
`---------------------------

Best,
mc

-- 
Fetch my gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 7E3CA33F

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 0 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

• * Re: org-comment-string fontification stopped working in sublevel headlines
    2015-08-23 14:54 org-comment-string fontification stopped working in sublevel headlines Martin Carlé
  @ 2015-08-23 19:56 ` Samuel Wales
    2015-08-23 20:50 ` Nicolas Goaziou
    1 sibling, 0 replies; 3+ messages in thread
  From: Samuel Wales @ 2015-08-23 19:56 UTC (permalink / raw)
    To: Martin Carlé; +Cc: Org-Mode mailing list
  
  if not already done, perhaps the ert stuff could always test stuff
  that is on lower levels also?
  
  ^ permalink raw reply	[flat|nested] 3+ messages in thread

• * Re: org-comment-string fontification stopped working in sublevel headlines
    2015-08-23 14:54 org-comment-string fontification stopped working in sublevel headlines Martin Carlé
    2015-08-23 19:56 ` Samuel Wales
  @ 2015-08-23 20:50 ` Nicolas Goaziou
    1 sibling, 0 replies; 3+ messages in thread
  From: Nicolas Goaziou @ 2015-08-23 20:50 UTC (permalink / raw)
    To: Martin Carlé; +Cc: Org-Mode mailing list
  
  Hello
  
  Martin Carlé <mc@aiguphonie.com> writes:
  
  > guess the commit c27c101f (08/16/2015 04:14 PM) with the title "org.el: Fix `org-comment-string' fontification" has chosen a bit too harsh 'fixation' method:
  >
  > Since then, the 'org-special-keyword' face for 'COMMENT' is not
  > applied to heading of lower levels any more but only to the top one.
  
  Fixed. Thank you.
  
  > The minimal example below also demonstrates another possibly
  > unintended fontification. Bold and italic faces (or the other options
  > of http://orgmode.org/org.html#Emphasis-and-monospace) are extended
  > across lists which they probably should not.
  
  Yes, they should not. However there are limits to regexp based
  fontification. We need to rewrite fontification process to handle this
  properly, but we're not there yet.
  
  
  Regards,
  
  -- 
  Nicolas Goaziou
  
  ^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-23 20:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-23 14:54 org-comment-string fontification stopped working in sublevel headlines Martin Carlé
2015-08-23 19:56 ` Samuel Wales
2015-08-23 20:50 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).