emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

* undo bug (plus a plain list bug)
@ 2007-03-27 19:06 Eddward DeVilla
  2007-03-28 18:38 ` Carsten Dominik
  0 siblings, 1 reply; 3+ messages in thread
From: Eddward DeVilla @ 2007-03-27 19:06 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 1739 bytes --]

Hi,

   I found a bug with undo and selection.  While putting together a simple
recreate, I also found a buglet involving A-left/A-right on plain lists.
First I'll describe the list bug.  If you have a plain list before the first
heading you can't use A-left or A-right to promote or demote list items.  So
given the file:

==== test 1 =========

  - Stooge
    - moe
    - larry
    - curly

==================

If you got to the line with moe on it and use A-left to promote it  I would
expect to see

===== test 1 prime =======

  - Stooge
   - moe
    - larry
    - curly

======================

It doesn't work because it's before the first heading.  Not a big deal, but
I though I'd mention it.

The second is more of an issue for someone like me who tends to live by undo
and is also sloppy about have a selection.  Given the file

==== test 2 =========

* brilliant
  - Stooge
    - moe
    - larry
    - curly

==================

Now go to the line with moe and press A-left twice to get the file:  (note:
moe indented twice.  larry and curly indented once)

==== test 2 prime ====

* brilliant
  - Stooge
  - moe
   - larry
   - curly

=================

Now select the region containing lines with moe and larry using what ever
method you like.  (The mouse is easy.)  Do two undos.  I would expect it to
undo both promotes, restoring the file back to its contents in test 2.
Instead I get:  (curly never got demoted)

==== test 2 double prime ====

* brilliant
  - Stooge
    - moe
    - larry
   - curly

========================

I'm assuming that regional undos are not a feature I'm unfamiliar with.
This is with emacs 21.2.1 on cygwin running org 4.69a.  I've seen similar on
21.1.1 on AIX and an older version org.

Edd

[-- Attachment #1.2: Type: text/html, Size: 2309 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 3+ messages in thread

• * Re: undo bug (plus a plain list bug)
    2007-03-27 19:06 undo bug (plus a plain list bug) Eddward DeVilla
  @ 2007-03-28 18:38 ` Carsten Dominik
    2007-03-29  1:49   ` Eddward DeVilla
    0 siblings, 1 reply; 3+ messages in thread
  From: Carsten Dominik @ 2007-03-28 18:38 UTC (permalink / raw)
    To: Eddward DeVilla; +Cc: emacs-orgmode
  
  
  On Mar 27, 2007, at 21:06, Eddward DeVilla wrote:
  
  > Hi,
  >
  >    I found a bug with undo and selection.  While putting together a 
  > simple recreate, I also found a buglet involving A-left/A-right on 
  > plain lists.  First I'll describe the list bug.  If you have a plain 
  > list before the first heading you can't use A-left or A-right to 
  > promote or demote list items.  So given the file:
  >
  > ==== test 1 =========
  >
  >    - Stooge
  >      - moe
  >      - larry
  >      - curly
  >
  >  ==================
  >
  > If you got to the line with moe on it and use A-left to promote it  I 
  > would expect to see
  >
  > It doesn't work because it's before the first heading.  Not a big 
  > deal, but I though I'd mention it. 
  
  This is fixed now, thanks.
  
  > The second is more of an issue for someone like me who tends to live 
  > by undo and is also sloppy about have a selection.  Given the file
  >
  > ==== test 2 =========
  >
  > * brilliant
  >    - Stooge
  >      - moe
  >      - larry
  >      - curly
  >
  >  ==================
  >
  > Now go to the line with moe and press A-left twice to get the file:  
  > (note: moe indented twice.  larry and curly indented once)
  >
  > ==== test 2 prime ====
  >
  >  * brilliant
  >   - Stooge
  >   - moe
  >    - larry
  >    - curly
  >
  > =================
  >
  > Now select the region containing lines with moe and larry using what 
  > ever method you like.  (The mouse is easy.)  Do two undos.  I would 
  > expect it to undo both promotes, restoring the file back to its 
  > contents in test 2.  Instead I get:  (curly never got demoted)
  >
  > ==== test 2 double prime ====
  >
  > * brilliant
  >   - Stooge
  >     - moe
  >     - larry
  >    - curly
  
  I think this result is correct, because Emacs only does undo in the 
  region.  curley is notpart of the region, so its promotion (as subitem 
  of moe) should not be undone.  Am I missing something?
  
  - Carsten
  
  ^ permalink raw reply	[flat|nested] 3+ messages in thread

• • * Re: undo bug (plus a plain list bug)
      2007-03-28 18:38 ` Carsten Dominik
    @ 2007-03-29  1:49   ` Eddward DeVilla
      0 siblings, 0 replies; 3+ messages in thread
    From: Eddward DeVilla @ 2007-03-29  1:49 UTC (permalink / raw)
      To: Carsten Dominik; +Cc: emacs-orgmode
    
    On 3/28/07, Carsten Dominik <dominik@science.uva.nl> wrote:
    > On Mar 27, 2007, at 21:06, Eddward DeVilla wrote:
    > > The second is more of an issue for someone like me who tends to live
    > > by undo and is also sloppy about have a selection. Given the file
    > >
    > > ==== test 2 =========
    > >
    > > * brilliant
    > >   - Stooge
    > >   - moe
    > >   - larry
    > >   - curly
    > >
    > >  ==================
    > >
    > > Now go to the line with moe and press A-left twice to get the file:
    > > (note: moe indented twice. larry and curly indented once)
    > >
    > > ==== test 2 prime ====
    > >
    > >  * brilliant
    > > - Stooge
    > > - moe
    > > - larry
    > > - curly
    > >
    > > =================
    > >
    > > Now select the region containing lines with moe and larry using what
    > > ever method you like. (The mouse is easy.) Do two undos. I would
    > > expect it to undo both promotes, restoring the file back to its
    > > contents in test 2. Instead I get: (curly never got demoted)
    > >
    > > ==== test 2 double prime ====
    > >
    > > * brilliant
    > > - Stooge
    > > - moe
    > > - larry
    > > - curly
    >
    > I think this result is correct, because Emacs only does undo in the
    > region.  curley is notpart of the region, so its promotion (as subitem
    > of moe) should not be undone.  Am I missing something?
    
    I guess it could be a feature of emacs.  I've never noticed outside of
    org-mode and found it confusing.  I should be able to get rid of the
    region and try undos from there and cycle back to the original state
    then right?  I'll play with it some more.
    
    Thanks,
    Edd
    
    ^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-03-29  1:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-27 19:06 undo bug (plus a plain list bug) Eddward DeVilla
2007-03-28 18:38 ` Carsten Dominik
2007-03-29  1:49   ` Eddward DeVilla

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).