* Re: packages submissions : ob-sql-session and org-blog
[not found] ` <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net>
@ 2024-09-17 10:00 ` Phil Estival
2024-09-17 22:25 ` Adam Porter
0 siblings, 1 reply; 5+ messages in thread
From: Phil Estival @ 2024-09-17 10:00 UTC (permalink / raw)
To: Adam Porter; +Cc: emacs-devel, Org Mode List
* [2024-09-11 05:01] Adam Porter:
> Hi Phil,
>
> A quick, initial suggestion: it would be good to reformat the Lisp code
> in both projects, as I see several cases of incorrect indentation,
> hanging parens, extra blank lines, etc, and some of them would make the
> code hard to read. For my Lisp editing, I use aggressive-indent-mode,
> which ensures that the code is always indented correctly. For some
> other reformatting, Oleh Krehel's Lispy package has commands to help.
Hi Adam,
> Also, for org-sql-session (which sounds very useful), it would be good
> to compare and contrast it with the package it's meant to supersede.
The following comparison was added to the readme file.
ob-sql-mode :
- is very simple : forward the sql source through `sql-redirect'
- has a test suite
- but gives clunky output
- no :results table
- sql client shell commands messes up output
- prompt again for connection parameters when restarting a session
ob-sql-session :
- handle large results
- has :results tables
- accept header variables (:var)
- accept sql client shell commands
- keep login parameters
- prompt only for blank connection parameters
- can use `with-environment-variables'
- provide some more tests
> since it's meant to integrate with org-babel, it might be good to
> discuss its inclusion on the Org mailing list also.
CC-ing the Org mailing list.
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: packages submissions : ob-sql-session and org-blog
2024-09-17 10:00 ` packages submissions : ob-sql-session and org-blog Phil Estival
@ 2024-09-17 22:25 ` Adam Porter
2024-09-18 1:41 ` package submission : ob-sql-session Phil Estival
0 siblings, 1 reply; 5+ messages in thread
From: Adam Porter @ 2024-09-17 22:25 UTC (permalink / raw)
To: Phil Estival; +Cc: emacs-devel, Org Mode List
Hi Phil,
On 9/17/24 05:00, Phil Estival wrote:
>> Also, for org-sql-session (which sounds very useful), it would be good
>> to compare and contrast it with the package it's meant to supersede.
>
> The following comparison was added to the readme file.
>
> ob-sql-mode :
> - is very simple : forward the sql source through `sql-redirect'
> - has a test suite
> - but gives clunky output
> - no :results table
> - sql client shell commands messes up output
> - prompt again for connection parameters when restarting a session
>
> ob-sql-session :
> - handle large results
> - has :results tables
> - accept header variables (:var)
> - accept sql client shell commands
> - keep login parameters
> - prompt only for blank connection parameters
> - can use `with-environment-variables'
> - provide some more tests
>
>> since it's meant to integrate with org-babel, it might be good to
>> discuss its inclusion on the Org mailing list also.
To be clear, this makes 3 implementations of SQL support for Org Babel
that I know of:
1. The built-in Org Babel SQL support, aka ob-sql, documented at
<https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-sql.html>
2. ob-sql-mode, hosted at <https://github.com/nikclayton/ob-sql-mode>,
which advertises itself as "an alternative backend for Org-Babel SQL SRC
blocks that uses sql-mode to evaluate the query instead of Org-Babel's
built-in SQL backends."
3. Your new ob-sql-session library.
You've mentioned how your library compares to ob-sql-mode, but how does
it compare to the built-in ob-sql library?
Thanks,
Adam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: package submission : ob-sql-session
2024-09-17 22:25 ` Adam Porter
@ 2024-09-18 1:41 ` Phil Estival
2024-10-20 12:34 ` Ihor Radchenko
0 siblings, 1 reply; 5+ messages in thread
From: Phil Estival @ 2024-09-18 1:41 UTC (permalink / raw)
To: Adam Porter; +Cc: emacs-devel, Org Mode List
Hi Adam,
* [2024-09-18 00:25] Adam Porter:
>
> Hi Phil,
>
> On 9/17/24 05:00, Phil Estival wrote:
>
>>> Also, for org-sql-session (which sounds very useful), it would be good
>>> to compare and contrast it with the package it's meant to supersede.
>>
>> The following comparison was added to the readme file.
>>
>> ob-sql-mode :
>> - is very simple : forward the sql source through `sql-redirect'
>> - has a test suite
>> - but gives clunky output
>> - no :results table
>> - sql client shell commands messes up output
>> - prompt again for connection parameters when restarting a session
>>
>> ob-sql-session :
>> - handle large results
>> - has :results tables
>> - accept header variables (:var)
>> - accept sql client shell commands
>> - keep login parameters
>> - prompt only for blank connection parameters
>> - can use `with-environment-variables'
>> - provide some more tests
>>
>>> since it's meant to integrate with org-babel, it might be good to
>>> discuss its inclusion on the Org mailing list also.
> To be clear, this makes 3 implementations of SQL support for Org Babel
> that I know of:
>
> 1. The built-in Org Babel SQL support, aka ob-sql, documented at
> <https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-sql.html>
>
> 2. ob-sql-mode, hosted at <https://github.com/nikclayton/ob-sql-mode>,
> which advertises itself as "an alternative backend for Org-Babel SQL SRC
> blocks that uses sql-mode to evaluate the query instead of Org-Babel's
> built-in SQL backends."
>
> 3. Your new ob-sql-session library.
>
> You've mentioned how your library compares to ob-sql-mode, but how does
> it compare to the built-in ob-sql library?
>
Here is a comparison with ob-sql-mode
ob-sql-session exists is for session support, which is in the TODOs
of ob-sql.
- ob-sql command execution relies on org-babel-eval
(→ process-file → call-process).
- ob-sql-session runs an inferior process (in which
sqli-interactive-mode can be activated when needed).
The process output is filtered (e.g. results and prompts).
When a session is demanded, this shell stays open for further commands
and can keep a state (typically, when given special SQL commands).
|-----------+----------------------------+----------------------------|
| | ob-sql | ob-sql-session |
|-----------+----------------------------+----------------------------|
| Feat. | - cmdline | - support for sessions |
| | - colnames as header arg | - optionnal colnames |
|-----------+----------------------------+----------------------------|
| TODO | | |
|-----------+----------------------------+----------------------------|
| | - support for sessions | - colnames as header arg |
| | - support for more engines | - support for more engines |
|-----------+----------------------------+----------------------------|
| engines | | |
| supported | | |
|-----------+----------------------------+----------------------------|
| | - mysql | - Postgresql |
| | - dbi | - sqlite |
| | - mssql | |
| | - sqsh | |
| | - postgresql | |
| | - oracle | |
| | - vertica | |
| | - saphana | |
|-----------+----------------------------+----------------------------|
ob-sql-session adapts sql-connect of sql.el by declaring
ob-sql-connect, in order to prompt only for missing connection
parameters.
- ob-sql defines org-babel-sql-dbstring-[engine]
to be provided on a shell command line.
- likewise, ob-sql-session has to define
- a connection string,
- the prompt,
- and the terminal command prefix
for a every supported SQL client shell (or "engines")
- ob-sql-session requires sql.el.
With the above defined, it should be compatible
with most database of the sql.el's zoo. maybe.
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: package submission : ob-sql-session
2024-09-18 1:41 ` package submission : ob-sql-session Phil Estival
@ 2024-10-20 12:34 ` Ihor Radchenko
2024-11-04 18:16 ` Phil Estival
0 siblings, 1 reply; 5+ messages in thread
From: Ihor Radchenko @ 2024-10-20 12:34 UTC (permalink / raw)
To: Phil Estival; +Cc: Adam Porter, emacs-devel, Org Mode List
Phil Estival <pe@7d.nz> writes:
>>> ob-sql-session :
>>> - handle large results
>>> - has :results tables
>>> - accept header variables (:var)
>>> - accept sql client shell commands
>>> - keep login parameters
>>> - prompt only for blank connection parameters
>>> - can use `with-environment-variables'
>>> - provide some more tests
Have you considered integrating it into ob-sql itself?
If not, what are the obstacles?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: package submission : ob-sql-session
2024-10-20 12:34 ` Ihor Radchenko
@ 2024-11-04 18:16 ` Phil Estival
0 siblings, 0 replies; 5+ messages in thread
From: Phil Estival @ 2024-11-04 18:16 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Adam Porter, emacs-devel, Org Mode List
* [2024-10-20 14:34] Ihor Radchenko:
> Phil Estival <pe@7d.nz> writes:
>
>>>> ob-sql-session :
>>>> - handle large results
>>>> - has :results tables
>>>> - accept header variables (:var)
>>>> - accept sql client shell commands
>>>> - keep login parameters
>>>> - prompt only for blank connection parameters
>>>> - can use `with-environment-variables'
>>>> - provide some more tests
>
> Have you considered integrating it into ob-sql itself?
> If not, what are the obstacles?
>
Hello Ihor,
yes I have. It grows ob-sql by approximately 300 lines.
There are rooms for improvements.
https://github.com/flintforge/ob-sql-session/blob/main/ob-sql.el
Current status :
- added support of :sessions to ob-sql.el, by merging ob-sql-session.el
- restored support for sqlite (even if there is ob-sqlite.el)
- added composite types for options
- moved options from org-babel to a new group org-babel-sql
TODO :
- use `org-babel-prep-session'
- verify headers and columns options
- check use and storage of :dbconnection
- minimize writings of temporary files
- Tests
Cheers,
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-04 18:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <b1ca8e9e-be59-4740-8ea8-c3ebd4ba56fe@7d.nz>
[not found] ` <daabaaef-70a0-4e4a-b0f9-64e8c05dcb21@alphapapa.net>
2024-09-17 10:00 ` packages submissions : ob-sql-session and org-blog Phil Estival
2024-09-17 22:25 ` Adam Porter
2024-09-18 1:41 ` package submission : ob-sql-session Phil Estival
2024-10-20 12:34 ` Ihor Radchenko
2024-11-04 18:16 ` Phil Estival
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).